Closed
Bug 1106168
Opened 11 years ago
Closed 10 years ago
Call SIM indicator is misaligned in RTL
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(b2g-v2.2 verified, b2g-master verified)
VERIFIED
FIXED
2.2 S4 (23jan)
People
(Reporter: drs, Assigned: drs)
References
Details
(Whiteboard: [c=1])
Attachments
(5 files)
187.60 KB,
image/png
|
Details | |
1.59 KB,
patch
|
gsvelto
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Diff | Splinter Review |
248.25 KB,
image/png
|
Carol
:
ui-review+
|
Details |
165.97 KB,
image/png
|
Details | |
163.88 KB,
image/png
|
Details |
The Callscreen SIM indicator is misaligned with the duration in RTL mode. It should be on the right, but it's on the left, as it would be in LTR mode.
Assignee | ||
Comment 1•11 years ago
|
||
PR: https://github.com/mozilla-b2g/gaia/pull/26562
I snuck in a fix for the alignment of the contact/phone number text. It's minor enough that I don't think it's worth filing another bug for.
Attachment #8530445 -
Flags: review?(gtorodelvalle)
Assignee | ||
Comment 2•11 years ago
|
||
Carol, I nudged down the SIM indicator by 0.5rem so that Arabic text in the duration field, such as the translation of "connecting", would fit without overlapping with the indicator.
Attachment #8530446 -
Flags: ui-review?(chuang)
Assignee | ||
Comment 4•11 years ago
|
||
Comment on attachment 8530445 [details] [diff] [review]
Fix alignment of Callscreen SIM indicator in RTL mode.
I'll take this to completion since it's so small. Gabriele, please review this since Germán is on PTO.
Flags: needinfo?(drs.bugzilla)
Attachment #8530445 -
Flags: review?(gtorodelvalle) → review?(gsvelto)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8530446 [details]
Proposed visual design after fix
Toggling UI review for visibility.
Assignee | ||
Updated•11 years ago
|
Attachment #8530446 -
Flags: ui-review?(chuang)
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 8530446 [details]
Proposed visual design after fix
Carol, please have a look at this as in comment 2.
Attachment #8530446 -
Flags: ui-review?(chuang)
Comment 7•11 years ago
|
||
Comment on attachment 8530445 [details] [diff] [review]
Fix alignment of Callscreen SIM indicator in RTL mode.
Review of attachment 8530445 [details] [diff] [review]:
-----------------------------------------------------------------
Overall this looks good to me, just one question (see below).
::: apps/callscreen/style/oncall.css
@@ +959,5 @@
>
> + html[dir="rtl"] .big-duration .sim {
> + left: auto;
> + right: 0;
> + }
Is this required to properly align the text to the above duration in RTL mode? This CSS has become really complicated, let's hope we'll be able to simplify it some day :-(
Attachment #8530445 -
Flags: review?(gsvelto) → review+
Updated•11 years ago
|
Attachment #8530446 -
Flags: ui-review?(chuang) → ui-review+
Assignee | ||
Comment 9•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
status-b2g-v2.2:
--- → affected
status-b2g-master:
--- → fixed
Flags: needinfo?(drs.bugzilla)
Resolution: --- → FIXED
Target Milestone: 2.2 S1 (5dec) → 2.2 S4 (23jan)
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8530445 [details] [diff] [review]
Fix alignment of Callscreen SIM indicator in RTL mode.
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Sub-bug of Dialer RTL support, bug 1071918.
[User impact] if declined: See attachment 8530437 [details].
[Testing completed]: Gabriele and I tested this.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None.
Attachment #8530445 -
Flags: approval-gaia-v2.2?
Updated•10 years ago
|
Attachment #8530445 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 11•10 years ago
|
||
Comment 12•10 years ago
|
||
RTL triage: P2 -- will make a best effort to get this into the 2.2 release.
Priority: -- → P2
Comment 13•10 years ago
|
||
This issue verified successfully on Flame 2.2:
Gaia-Rev e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/75a462a58d7a
Build-ID 20150121002607
Version 37.0a2
Device-Name flame
FW-Release 4.4.2
Refer to picture
Comment 14•10 years ago
|
||
Comment 15•10 years ago
|
||
This issue has been verified successfully on Flame 3.0.
Reproduce rate:0/5.
Attachment:Verify_RTL_SIM.png
Flame 3.0 build:
Gaia-Rev 740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko-Rev https://hg.mozilla.org/mozilla-central/rev/940118b1adcd
Build-ID 20150202010229
Version 38.0a1
Device-Name flame
FW-Release 4.4.2
FW-Incremental eng.cltbld.20150202.044915
FW-Date Mon Feb 2 04:49:25 EST 2015
Bootloader L1TC000118D0
Comment 16•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•