1106168 - Call SIM indicator is misaligned in RTL

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[Doug Sherk (:drs) (inactive)]

Attachment: Screenshot

The Callscreen SIM indicator is misaligned with the duration in RTL mode. It should be on the right, but it's on the left, as it would be in LTR mode.

Comment 1

[Doug Sherk (:drs) (inactive)]

Attachment: Fix alignment of Callscreen SIM indicator in RTL mode.

PR: https://github.com/mozilla-b2g/gaia/pull/26562

I snuck in a fix for the alignment of the contact/phone number text. It's minor enough that I don't think it's worth filing another bug for.

Comment 2

[Doug Sherk (:drs) (inactive)]

Attachment: Proposed visual design after fix

Carol, I nudged down the SIM indicator by 0.5rem so that Arabic text in the duration field, such as the translation of "connecting", would fit without overlapping with the indicator.

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

Any updates regarding this bug ?

Comment 4

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8530445 [details] [diff] [review]
Fix alignment of Callscreen SIM indicator in RTL mode.

I'll take this to completion since it's so small. Gabriele, please review this since Germán is on PTO.

Comment 5

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8530446 [details]
Proposed visual design after fix

Toggling UI review for visibility.

Comment 6

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8530446 [details]
Proposed visual design after fix

Carol, please have a look at this as in comment 2.

Comment 7

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8530445 [details] [diff] [review]
Fix alignment of Callscreen SIM indicator in RTL mode.

Review of attachment 8530445 [details] [diff] [review]:
-----------------------------------------------------------------

Overall this looks good to me, just one question (see below).

::: apps/callscreen/style/oncall.css
@@ +959,5 @@
>  
> +  html[dir="rtl"] .big-duration .sim {
> +    left: auto;
> +    right: 0;
> +  }

Is this required to properly align the text to the above duration in RTL mode? This CSS has become really complicated, let's hope we'll be able to simplify it some day :-(

Comment 8

[Gregor Wagner [:gwagner]]

Can we land this?

Comment 9

[Doug Sherk (:drs) (inactive)]

https://github.com/mozilla-b2g/gaia/commit/240448df5338fa29924b38ea693e2d09cf93c7fb

Comment 10

[Doug Sherk (:drs) (inactive)]

Comment on attachment 8530445 [details] [diff] [review]
Fix alignment of Callscreen SIM indicator in RTL mode.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Sub-bug of Dialer RTL support, bug 1071918.
[User impact] if declined: See attachment 8530437 [details].
[Testing completed]: Gabriele and I tested this.
[Risk to taking this patch] (and alternatives if risky): Low.
[String changes made]: None.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/b9da64ae4e704476b69102b874f1282ed2fd9598

Comment 12

[Dylan Oliver [:doliver]]

RTL triage: P2 -- will make a best effort to get this into the 2.2 release.

Comment 13

[Elie]

This issue verified successfully on Flame 2.2:
Gaia-Rev        e4f9b5da3751798f9cc5d95f302c30722cc11fca
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/75a462a58d7a
Build-ID        20150121002607
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
Refer to picture

Comment 14

[Elie]

Attachment: 2015-01-21-05-12-55.png

Comment 15

[Coler]

This issue has been verified successfully on Flame 3.0.
Reproduce rate:0/5.
Attachment:Verify_RTL_SIM.png

Flame 3.0 build:

Gaia-Rev        740c7c2330d08eb9298597e0455f53d4619bbc1a
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/940118b1adcd
Build-ID        20150202010229
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150202.044915
FW-Date         Mon Feb  2 04:49:25 EST 2015
Bootloader      L1TC000118D0

Comment 16

[Coler]

Attachment: Verify_RTL_SIM.png