Closed Bug 1106240 Opened 6 years ago Closed 6 years ago
Search category icon in in-content prefs looks squashed
The correct image region is : rect(0px, 192px, 24px, 168px)
Component: Theme → Preferences
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Attachment #8530504 - Flags: review?(dao)
Accidently added px after 0.
Comment on attachment 8530505 [details] [diff] [review] Patch v1.1 Approval Request Comment [Feature/regressing bug #]: bug 1088660 [User impact if declined]: Squashed in-content prefs search category icon (in-content prefs are enabled on aurora by default, but beta users using in-content prefs could benefit this as well without any risks) [Describe test coverage new/current, TBPL]: Will land on m-c [Risks and why]: Very very low, this is just a one line CSS change [String/UUID change made/needed]: None
Technically speaking, disabled by default means unaffected, as the status flags are primarily about what we release to end users. However, I agree it's fine to uplift this small patch to aurora...
The size of the icons.png file is 192px × 24px. Is it expected that we are using an image region that is in part outside the image?
Uh, sorry, I confused the sizes before and after the patch. Please ignore comment 5.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Verified fixed on Windows 7 64bit, Mac OSX 10.9.5 and Ubuntu 13.10 32bit using latest Nightly 37.0a1 (buildID: 20141204030201) and latest DeveloperEdition 36.0a2 (buildID: 20141204004001). I will verify the bug on Firefox 35 Beta 2 and I will change the STATUS afterwards.
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 35 Beta 3 (buildID: 20141211142524).
You need to log in before you can comment on or make changes to this bug.