Search category icon in in-content prefs looks squashed

VERIFIED FIXED in Firefox 35

Status

()

defect
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: ntim, Assigned: ntim)

Tracking

unspecified
Firefox 37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox35 verified, firefox36 verified, firefox37 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
The correct image region is : rect(0px, 192px, 24px, 168px)
Assignee

Updated

5 years ago
Assignee

Updated

5 years ago
Component: Theme → Preferences
Component: Preferences → Theme
Assignee

Comment 1

5 years ago
Posted patch Patch (obsolete) — Splinter Review
Assignee: nobody → ntim007
Status: NEW → ASSIGNED
Attachment #8530504 - Flags: review?(dao)
Assignee

Comment 2

5 years ago
Posted patch Patch v1.1Splinter Review
Accidently added px after 0.
Attachment #8530504 - Attachment is obsolete: true
Attachment #8530504 - Flags: review?(dao)
Attachment #8530505 - Flags: review?(dao)
Attachment #8530505 - Flags: review?(dao) → review+
Assignee

Updated

5 years ago
Keywords: checkin-needed
Assignee

Comment 3

5 years ago
Comment on attachment 8530505 [details] [diff] [review]
Patch v1.1

Approval Request Comment
[Feature/regressing bug #]: bug 1088660 
[User impact if declined]: Squashed in-content prefs search category icon (in-content prefs are enabled on aurora by default, but beta users using in-content prefs could benefit this as well without any risks)
[Describe test coverage new/current, TBPL]: Will land on m-c
[Risks and why]: Very very low, this is just a one line CSS change
[String/UUID change made/needed]: None
Attachment #8530505 - Flags: approval-mozilla-beta?
Attachment #8530505 - Flags: approval-mozilla-aurora?
Technically speaking, disabled by default means unaffected, as the status flags are primarily about what we release to end users. However, I agree it's fine to uplift this small patch to aurora...
The size of the icons.png file is 192px × 24px. Is it expected that we are using an image region that is in part outside the image?
Uh, sorry, I confused the sizes before and after the patch. Please ignore comment 5.
https://hg.mozilla.org/mozilla-central/rev/6600cc9f2177
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Attachment #8530505 - Flags: approval-mozilla-beta?
Attachment #8530505 - Flags: approval-mozilla-beta+
Attachment #8530505 - Flags: approval-mozilla-aurora?
Attachment #8530505 - Flags: approval-mozilla-aurora+
Verified fixed on Windows 7 64bit, Mac OSX 10.9.5 and Ubuntu 13.10 32bit using latest Nightly 37.0a1 (buildID: 20141204030201) and latest DeveloperEdition 36.0a2 (buildID: 20141204004001). 

I will verify the bug on Firefox 35 Beta 2 and I will change the STATUS afterwards.
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 35 Beta 3 (buildID: 20141211142524).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.