Closed
Bug 1106240
Opened 11 years ago
Closed 11 years ago
Search category icon in in-content prefs looks squashed
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 37
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(1 file, 1 obsolete file)
|
976 bytes,
patch
|
dao
:
review+
Sylvestre
:
approval-mozilla-aurora+
Sylvestre
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
The correct image region is : rect(0px, 192px, 24px, 168px)
|
Assignee | |
Updated•11 years ago
|
Blocks: fx34-searchui
|
|
Assignee | |
Updated•11 years ago
|
Blocks: ship-incontent-prefs
Component: Theme → Preferences
|
||
Updated•11 years ago
|
Component: Preferences → Theme
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Comment 2•11 years ago
|
||
Accidently added px after 0.
Attachment #8530504 -
Attachment is obsolete: true
Attachment #8530504 -
Flags: review?(dao)
Attachment #8530505 -
Flags: review?(dao)
|
|
||
Updated•11 years ago
|
Attachment #8530505 -
Flags: review?(dao) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8530505 [details] [diff] [review]
Patch v1.1
Approval Request Comment
[Feature/regressing bug #]: bug 1088660
[User impact if declined]: Squashed in-content prefs search category icon (in-content prefs are enabled on aurora by default, but beta users using in-content prefs could benefit this as well without any risks)
[Describe test coverage new/current, TBPL]: Will land on m-c
[Risks and why]: Very very low, this is just a one line CSS change
[String/UUID change made/needed]: None
Attachment #8530505 -
Flags: approval-mozilla-beta?
Attachment #8530505 -
Flags: approval-mozilla-aurora?
|
|
Assignee | |
Updated•11 years ago
|
status-firefox34:
--- → affected
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
|
|
||
Comment 4•11 years ago
|
||
Technically speaking, disabled by default means unaffected, as the status flags are primarily about what we release to end users. However, I agree it's fine to uplift this small patch to aurora...
status-firefox34:
affected → ---
status-firefox35:
affected → ---
status-firefox36:
affected → ---
status-firefox37:
affected → ---
|
||
Comment 5•11 years ago
|
||
The size of the icons.png file is 192px × 24px. Is it expected that we are using an image region that is in part outside the image?
|
|
||
Comment 6•11 years ago
|
||
Uh, sorry, I confused the sizes before and after the patch. Please ignore comment 5.
|
||
Comment 7•11 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
|
||
Comment 8•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
|
||
Updated•11 years ago
|
|
|
||
Updated•11 years ago
|
Attachment #8530505 -
Flags: approval-mozilla-beta?
Attachment #8530505 -
Flags: approval-mozilla-beta+
Attachment #8530505 -
Flags: approval-mozilla-aurora?
Attachment #8530505 -
Flags: approval-mozilla-aurora+
|
||
Comment 9•11 years ago
|
||
|
||
Comment 10•11 years ago
|
||
Verified fixed on Windows 7 64bit, Mac OSX 10.9.5 and Ubuntu 13.10 32bit using latest Nightly 37.0a1 (buildID: 20141204030201) and latest DeveloperEdition 36.0a2 (buildID: 20141204004001).
I will verify the bug on Firefox 35 Beta 2 and I will change the STATUS afterwards.
|
|
||
Comment 11•11 years ago
|
||
Verified fixed on Windows 7 64bit, Ubuntu 13.10 32bit and Mac OSX 10.9.5 using Firefox 35 Beta 3 (buildID: 20141211142524).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•