Closed
Bug 1106255
Opened 9 years ago
Closed 9 years ago
Regression: Wrong viewport in content (Android)
Categories
(Firefox for Android Graveyard :: Toolbar, defect)
Tracking
(firefox36 fixed, firefox37 fixed, fennec36+)
RESOLVED
FIXED
Firefox 37
People
(Reporter: vlposta, Assigned: kats)
References
Details
(Keywords: regression, reproducible, testcase)
Attachments
(3 files)
82.66 KB,
image/png
|
Details | |
78.08 KB,
image/png
|
Details | |
774 bytes,
patch
|
dvander
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Android; Mobile; rv:37.0) Gecko/37.0 Firefox/37.0 Build ID: 20141129030207 Steps to reproduce: I see any web pages (this too) and set font in setting to large Actual results: Font is too small and i cannot read this pages - in older version 29141123 this problem not exist and font size on all web pages is OK Expected results: Font sizes same as in older version 20141123
Comment 1•9 years ago
|
||
Please provide an example page that you are using for testing.
Flags: needinfo?(vlposta)
Reporter | ||
Comment 2•9 years ago
|
||
Flags: needinfo?(vlposta)
Reporter | ||
Comment 3•9 years ago
|
||
Reporter | ||
Comment 4•9 years ago
|
||
Many pages have this isue and if i reply for example in disscusion (see attachmets please), i mus always manualy zoom ...
Comment 5•9 years ago
|
||
Assuming some content regression we should track this (as per filed against trunk and indication that this used to work). Is this happening on other sites? Do you have specific URLs?
tracking-fennec: --- → ?
Keywords: regression,
regressionwindow-wanted
Reporter | ||
Comment 6•9 years ago
|
||
On many sites, e.g. : http://www.novinky.cz/ http://www.novinky.cz/diskuse?id=385223&articleId=/domaci/354928-vanoce-neprekvapi-teploty-kolem-nuly-snehu-malo.html§ionId=8 http://www.parlamentnilisty.cz/ and other - in older build 20141123 this isue not exist and i mus now use this older build... :-(
Comment 7•9 years ago
|
||
Thanks. I was able to reproduce on a sample test-page of mine. I'll look for a regression-window.
Status: UNCONFIRMED → NEW
status-firefox37:
--- → affected
Ever confirmed: true
Flags: in-testsuite?
Summary: Font size on many pages is now too small → Regression: All default in content text-size is small
Comment 8•9 years ago
|
||
Last good revision: b379f1bc58e1 First bad revision: 285c55e9b40d Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml? fromchange=b379f1bc58e1&tochange=285c55e9b40d c3ad8948bea9 David Anderson — Put meta viewport support behind a pref (bug 1092450, r=kats). Reproducible on simple content my media test page @ http://people.mozilla.org/~atrain/mobile/tests/media.html
Blocks: 1092450
status-firefox36:
--- → affected
Flags: needinfo?(bugmail.mozilla)
Summary: Regression: All default in content text-size is small → Regression: Wrong viewport in content (Android)
Updated•9 years ago
|
Hardware: Other → ARM
Version: Firefox 37 → Firefox 36
Updated•9 years ago
|
Severity: normal → major
Updated•9 years ago
|
Component: General → Graphics, Panning and Zooming
Assignee | ||
Comment 9•9 years ago
|
||
Doh, my mistake. By turning off the pref on fennec we disabled font inflation, even though the viewport code in browser.js is still getting run just fine. I should have realized that would happen since i had to enable the pref for the font inflation tests. We just need to turn the pref back on in fennec.
Assignee: nobody → bugmail.mozilla
Flags: needinfo?(bugmail.mozilla)
Assignee | ||
Comment 10•9 years ago
|
||
Attachment #8530849 -
Flags: review?(dvander)
Comment on attachment 8530849 [details] [diff] [review] Patch Review of attachment 8530849 [details] [diff] [review]: ----------------------------------------------------------------- r=me assuming that should be "true"
Attachment #8530849 -
Flags: review?(dvander) → review+
Assignee | ||
Comment 12•9 years ago
|
||
Yup, sorry. Fixed and landed: https://hg.mozilla.org/integration/mozilla-inbound/rev/789bf02e6662 With try push: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=78552b1e8105
Comment 13•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/789bf02e6662
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Comment 14•9 years ago
|
||
This is needed on mozilla-aurora (36).
Assignee | ||
Updated•9 years ago
|
Assignee | ||
Comment 15•9 years ago
|
||
Comment on attachment 8530849 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: bug 1092450 [User impact if declined]: font inflation is completely disabled in fennec. [Describe test coverage new/current, TBPL]: on m-c, tested via automated tests [Risks and why]: low risk, just a pref change for fennec [String/UUID change made/needed]: none
Attachment #8530849 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Attachment #8530849 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 17•9 years ago
|
||
oh, this is fun, we have a regression in tsvgx: http://graphs.mozilla.org/graph.html#tests=%5B%5B281,63,29%5D%5D&sel=none&displayrange=30&datatype=running but since this looks related to the change 1.5 weeks prior which resulted in a regression: http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=c3ad8948bea9 I am going to call this a wash since our overall performance is not affected.
Updated•9 years ago
|
tracking-fennec: ? → 36+
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•