1106429 - docker-worker: Refactor log support to handle multiple containers

Status: RESOLVED WONTFIX

(Taskcluster :: Workers, defect)

Description

[James Lal [:lightsofapollo]]

Initially we only started one container per task now tasks can have at least 2 (and more soon once services land) currently we don't store logs of these tasks which means it is effectively impossible to debug them unless trying things out locally.

A simple fix is to change the way we handle logs instead of a single stream we use a structure like this:

 task.logs = {
   'task': { stream: stream, alias: 'live' }
 }

Then the logging features will process all entries such as the above in log uploading.

Comment 1

[James Lal [:lightsofapollo]]

Attachment: https://github.com/taskcluster/docker-worker/pull/62

Comment 2

[James Lal [:lightsofapollo]]

Worth noting that using services is measurable amount of overhead 200ms-2000ms to start a service and 2s -> 10s to stop / upload logs (as measured so far on my local and very slow vm)

Comment 3

[Greg Arndt [:garndt]]

Comment on attachment 8530931 [details] [review]
https://github.com/taskcluster/docker-worker/pull/62

Looks good but has changes made for the services PR included as well.

Comment 4

[Greg Arndt [:garndt]]

No longer being worked on because "services" features were halted.  Closing this for now until we decide if/when we want to handle multiple containers.