Closed Bug 110643 Opened 24 years ago Closed 24 years ago

[xlib] Minor Xlib toolkit cleanup ...

Categories

(Core :: XUL, enhancement)

Product:
Core
Component:
XUL
Platform:
All
Linux
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla0.9.7

People

(Reporter: roland.mainz, Assigned: roland.mainz)

References

Details

Attachments

(1 file, 5 obsolete files)

New patch for 2001-11-18-08-trunk
44.22 KB, patch
Details | Diff | Splinter Review
Minor Xlib-toolkit cleanup...
--> myself
Assignee: hyatt → Roland.Mainz
Accepting ...
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.7
Attached patch patch for 2001-11-14-08-trunk (obsolete) — — Splinter Review
Filed patch, requesting r= ...
Keywords: patch, review
Blocks: 79119
Summary: Minor Xlib toolkit cleanup ... → [xlib] Minor Xlib toolkit cleanup ...
Attachment #58268 - Attachment is obsolete: true
Attachment #58269 - Attachment is obsolete: true
Attached patch New patch to match r= timeless (obsolete) — — Splinter Review
Attachment #58271 - Attachment is obsolete: true
Attachment #58272 - Attachment is obsolete: true
Attachment #58273 - Flags: review+
Comment on attachment 58273 [details] [diff] [review] New patch to match r= timeless The patch needs work... for some reason "Print"/"cancel" buttons in the new print dialog are broken after aplying this patch... but why ?
Attachment #58273 - Flags: needs-work+
The problem is caused by the fact that |if (XtAppPending(app_context) == 0)| will never be true as we always have one Xt timer in the queue ...
I just replaced |if (XtAppPending(app_context) == 0)| with |if ((XtAppPending(app_context) & XtIMXEvent) == 0)| ... timeless, wanna checkin this one, please ?
Attachment #58273 - Attachment is obsolete: true
checked in
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: