1106455 - firefox refuses to load when only tab open was "Install Add-on"

Status: RESOLVED INACTIVE

(Toolkit :: Add-ons Manager, defect)

Description

[Humphrey P van Polanen Petel]

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:33.0) Gecko/20100101 Firefox/33.0
Build ID: 20141113143407

Steps to reproduce:

I was working in Linux
I switch from Linux to WindowsXP
Firefox asks my okay for add-ons
I accept
Firefox asks my okay for Microsoft .NET Framework Assistant add-on
I accept and click <Restart Firefox"
Firefox unloads
Firefox loads, display some tabs, including some Add-on screen 
I inadvertently close all tabs with <Ctrl-F4>
Firefox unloads
I restart Firefox


Actual results:

Firefox loads, flashes some Add-on screen and unloads


Expected results:

Firefox should have loaded with the Homepage as set in the Options

Note

Options are set to show tabs and windows from last time

Note

I hope I correctly remembered what happened

Comment 1

[Humphrey P van Polanen Petel]

After I started Firefox with an URL as parameter everything was okay again

Comment 2

[Humphrey P van Polanen Petel]

It is still happening on version 41

I open firefox and there are three tabs: one regular, two add-ons that it wishes me to verify
I accept both add-ons
I close the regular tab
I exit firefox
I restart firefox
Firefox loads and displays one (1) add-on tab and exits before I get a chance to read it

Comment 3

[Humphrey P van Polanen Petel]

Attachment: screen shots as evidence

Comment 4

[Humphrey P van Polanen Petel]

Attachment: screen shot 2

Comment 5

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

I couldn't reproduce this issue on xp x86. I've tested on:
Firefox 33.0(user agent: Mozilla/5.0 (Windows NT 5.1; rv:33.0) Gecko/20100101 Firefox/33.0)
Firefox 41.0(user agent: Mozilla/5.0 (Windows NT 5.1; rv:41.0) Gecko/20100101 Firefox/41.0, build id: 20150917150946)
latest release 42.0(user agent: Mozilla/5.0 (Windows NT 5.1; rv:42.0) Gecko/20100101 Firefox/42.0, build id: 20151029151421)
latest Nightly 45.0a1(user agent: Mozilla/5.0 (Windows NT 5.1; rv:45.0) Gecko/20100101 Firefox/45.0, build id: 20151111030207).
Please try to see if you can reproduce it on the latest versions, with a clean profile, safe mode. and provide the necessarily steps to reproduce it.

Comment 6

[Humphrey P van Polanen Petel]

Trying to reproduce this without add-ons (i.e. in safe mode) won't make help, because then there wouldn't be any add-on tabs asking me to accept.

Comment 7

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

When you install now add-ons on Firefox, a pop-up(doorhanger) notification appears in top left side. I couldn't reproduce the case when a new tab is opened with an URL containing "about:newaddon..." when trying to install one.
Can you please tell me what are the names of addons you were trying to instal or how to obtain that new tab for addon instalation URL ? It seams to me that if an addon is already instaled trough that URL and after a restart the browser reloads that tab and tries to install again the addon trough that URL, it causes this behavior.

Comment 8

[Dave Townsend [:mossop]]

This will happen with sideloaded add-ons. The add-on install tab closes itself if the add-on it is for is already enabled or no longer installed and so if this was the last tab it will cause the main window to close. We should replace the tab with the homepage in that case.

Comment 10

[Tony Mechelynck [:tonymec]]

(In reply to Dave Townsend [:mossop] from comment #8)
> This will happen with sideloaded add-ons. The add-on install tab closes
> itself if the add-on it is for is already enabled or no longer installed and
> so if this was the last tab it will cause the main window to close. We
> should replace the tab with the homepage in that case.

The homepage might be multitab (if "Use Current Pages" [Firefox] or "Use Current Group" [SeaMonkey] has been used to define it). In that case, loading the homepage might be less than ideal, but we should still load "something": maybe about:blank? The user would still be left with a usable browser, and if he really wants the full multitab homepage, clicking the Home button isn't hard.

In addition, the contents of a multitab homepage are defined differently in Firefox and SeaMonkey: another reason to load just one tab in that case.

Comment 11

[Tony Mechelynck [:tonymec]]

(In reply to Tony Mechelynck [:tonymec] from comment #10)
> (In reply to Dave Townsend [:mossop] from comment #8)
> > This will happen with sideloaded add-ons. The add-on install tab closes
> > itself if the add-on it is for is already enabled or no longer installed and
> > so if this was the last tab it will cause the main window to close. We
> > should replace the tab with the homepage in that case.
> 
> The homepage might be multitab (if "Use Current Pages" [Firefox] or "Use
> Current Group" [SeaMonkey] has been used to define it). In that case,
> loading the homepage might be less than ideal, but we should still load
> "something": maybe about:blank? The user would still be left with a usable
> browser, and if he really wants the full multitab homepage, clicking the
> Home button isn't hard.
> 
> In addition, the contents of a multitab homepage are defined differently in
> Firefox and SeaMonkey: another reason to load just one tab in that case.

Maybe load whatever it is that we load on a "new" tab, according to the user's Preferences?

Comment 12

[BMO Automation]

Per policy at https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Inactive_Bugs. If this bug is not an enhancement request or a bug not present in a supported release of Firefox, then it may be reopened.