1106647 - [Keyboard] Keyboard does NOT pop up when restarting with SIM PIN enabled and Screen Lock Disabled.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Yeojin Chung [:YeojinC]]

Attachment: logcat_20141201_KeyboardNotAppearing.txt

Description:
When the user restarts the device with the SIM PIN enabled and Screen Lock disabled, the number keypad does not pop up on the SIM PIN screen. 

Pre-requisite: Have 1 SIM in the device.
   
Repro Steps:
1) Update a Flame device to BuildID: 20141201040205.
2) Go to Settings > SIM Manager > SIM Security > Enable SIM PIN 1.
3) Go to Settings > Screen Lock > Disable Lock Screen.
4) Restart the phone.
5) On the "Enter SIM 1 PIN" screen, tap the number field.
  
Actual:
The keypad does NOT appear, and the user cannot enter the PIN.
  
Expected: 
The keypad pops up automatically, or appear when the number field is tapped.

Note:
The keyboard pops up when the user taps under the number field and taps the number field afterwards.
  
Environmental Variables:
Device: Flame 2.2 Master (319mb, KK, Full Flash)
BuildID: 20141201040205
Gaia: 39214fb22c203e8849aaa1c27b773eeb73212921
Gecko: 08be3008650f
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Repro frequency: 100%
See attached: video clip, logcat
http://youtu.be/37FMKqrBmG0

Comment 1

[Yeojin Chung [:YeojinC]]

This issue does NOT reproduce on Flame 2.1.

Result: The keyboard pops up automatically when the device is restarted with SIM PIN on and Lock Screen off.

Device: Flame 2.1 (319mb, KK, Full Flash)
BuildID: 20141201001201
Gaia: ccb49abe412c978a4045f0c75abff534372716c4
Gecko: 18fb67530b22
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 34.0 (2.1)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

[Blocking Requested - why for this release]:

User is unable to type in their SIM Pin to unlock their SIM aftwer waking the phone. Basic functionality broken. Regression. Nominating to block 2.2

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

b2g-inbound regression window:

Last Working Environmental Variables:
Device: Flame
BuildID: 20141121141747
Gaia: e189d696f89dd71471d0aa4bdbf8cca3831aeadb
Gecko: b674e7639abc
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken Environmental Variables:
Device: Flame
BuildID: 20141121143245
Gaia: 2cc24e5892c3e84c6fef56ee6279cfb155e538a2
Gecko: b1266e9a751f
Version: 36.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken Gaia & Last Working Gecko - issue DOES repro
Gaia: 2cc24e5892c3e84c6fef56ee6279cfb155e538a2
Gecko: b674e7639abc

First Broken Gecko & Last Working Gaia - issue does NOT repro
Gaia: e189d696f89dd71471d0aa4bdbf8cca3831aeadb
Gecko: b1266e9a751f

Gaia pushlog:
https://github.com/mozilla-b2g/gaia/compare/e189d696f89dd71471d0aa4bdbf8cca3831aeadb...2cc24e5892c3e84c6fef56ee6279cfb155e538a2

Caused by Bug 1090859.

Comment 4

[Joshua Mitchell (Inactive)]

Broken by the patch to Bug 1090859 - can you take a look Alberto?

Comment 5

[Alberto Pastor [:albertopq]]

Yep, I'll take a look. Thanks!

Comment 6

[Alberto Pastor [:albertopq]]

Attachment: Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26613

I thought that we were missing simlockrequestfocus and simlockcreated events, so I added them, but apparently are being duplicated with 'system-dialog-requestfocus' and 'system-dialog-created', which causes the keyboard not being focused correctly. :alive, you did the refactor regarding this, so you probably are the right person to check if I'm correct. Thanks!

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8532555 [details] [review]
Link to Pull Request: https://github.com/mozilla-b2g/gaia/pull/26613

Thanks!

Comment 8

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/eb20f0a536f510ae08311e2df7a62333b51d57a0

Comment 9

[KTucker [:KTucker][Inactive 3/4/2016]]

Sergey, please verify this on Monday;s build.

Comment 10

[sarsenyev]

Verified the issue is fixed on 2.2 Flame
Keyboard pops up on the "Enter SIM PIN" code, when unlocked screen

"Flame 2.2

Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20141208040202
Gaia: 0e429d970c160e580e19e61ad8ff5612de159f00
Gecko: c4c7442e9113
Gonk: 48835395daa6a49b281db62c50805bd6ca24077e
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0"

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

2.2+ all fixed regressions -- reset if disagree.