1106707 - Add in support for win32/win64 builds

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Steve Fink [:sfink] [:s:]]

I am slowly getting closer to enabling spidermonkey builds on win32 and win64. There are some necessary bits distributed among the mozharness scripts and config and the buildbot config that I need here.

The main build script for spidermonkey has now moved in-tree. spidermonkey.sh is now just an adapter script to allow the in-tree autospider.sh to be invoked from buildbot. (Well, it also still contains the logic to do the full build, for older branches.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Add in support for win32/win64 builds

--platform allows specifying win32 vs win64

The Windows builders require mozmake, but are currently running MozillaBuild 1.5.1 (!) which does not contain it, so we need to fetch it from tooltool.

Comment 2

[[e-mail] (:bhearsum)]

Comment on attachment 8531119 [details] [diff] [review]
Add in support for win32/win64 builds

Review of attachment 8531119 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/spidermonkey_builds/spidermonkey.sh
@@ +12,1 @@
>  

This is something that's defined in the production/staging configs, so it should probably be passed through from there if possible. (Eg: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/production_config.py#L88). Everything else seems fine.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Add in support for win32/win64 builds

I'll pass it through a command line option.

Comment 4

[Steve Fink [:sfink] [:s:]]

Attachment: Pass through the platform and the tooltool server urls

Give the tooltool server and the platform (so spidermonkey.sh/autospider.sh can distinguish between win32 and win64 builds.)

Comment 5

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/build/buildbotcustom/rev/ef812b5bdee9
https://hg.mozilla.org/build/tools/rev/72c479940cfb

Comment 6

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/ef812b5bdee9

Comment 7

[Steve Fink [:sfink] [:s:]]

This didn't completely work. I think I'm pulling the tooltool_url_list from the wrong config. Trying out a fix now.

Comment 8

[Steve Fink [:sfink] [:s:]]

Attachment: Use correct config dict for tooltool_url_list

According to my diff, this should do the trick.

Comment 9

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/build/buildbotcustom/rev/f74d08aada8d

Comment 10

[Chris Cooper [:coop] (he/him)]

In production: https://hg.mozilla.org/build/buildbotcustom/rev/f74d08aada8d

Comment 11

[Chris Cooper [:coop] (he/him)]

(In reply to Chris Cooper [:coop] from comment #10)
> In production: https://hg.mozilla.org/build/buildbotcustom/rev/f74d08aada8d

I think this may have caused some spidermonkey-specific bustage, as reported by philor:

https://treeherder.mozilla.org/logviewer.html#?job_id=5771113&repo=mozilla-inbound

Comment 12

[Steve Fink [:sfink] [:s:]]

Attachment: Allow the variant to be mixed in with other params

Argh! Put the arguments out of order. Fix the build script to allow any order.

Comment 13

[Steve Fink [:sfink] [:s:]]

https://hg.mozilla.org/build/tools/rev/53d91399c36d

Comment 14

[Steve Fink [:sfink] [:s:]]

This is working, finally.

Comment 15

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

\o/