If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Add in support for win32/win64 builds

RESOLVED FIXED

Status

Release Engineering
General Automation
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 1 obsolete attachment)

(Assignee)

Description

3 years ago
I am slowly getting closer to enabling spidermonkey builds on win32 and win64. There are some necessary bits distributed among the mozharness scripts and config and the buildbot config that I need here.

The main build script for spidermonkey has now moved in-tree. spidermonkey.sh is now just an adapter script to allow the in-tree autospider.sh to be invoked from buildbot. (Well, it also still contains the logic to do the full build, for older branches.)
(Assignee)

Comment 1

3 years ago
Created attachment 8531119 [details] [diff] [review]
Add in support for win32/win64 builds

--platform allows specifying win32 vs win64

The Windows builders require mozmake, but are currently running MozillaBuild 1.5.1 (!) which does not contain it, so we need to fetch it from tooltool.
Attachment #8531119 - Flags: review?(bhearsum)
Comment on attachment 8531119 [details] [diff] [review]
Add in support for win32/win64 builds

Review of attachment 8531119 [details] [diff] [review]:
-----------------------------------------------------------------

::: scripts/spidermonkey_builds/spidermonkey.sh
@@ +12,1 @@
>  

This is something that's defined in the production/staging configs, so it should probably be passed through from there if possible. (Eg: https://github.com/mozilla/build-buildbot-configs/blob/master/mozilla/production_config.py#L88). Everything else seems fine.
Attachment #8531119 - Flags: review?(bhearsum) → feedback+
(Assignee)

Comment 3

3 years ago
Created attachment 8540971 [details] [diff] [review]
Add in support for win32/win64 builds

I'll pass it through a command line option.
Attachment #8540971 - Flags: review?(bhearsum)
(Assignee)

Updated

3 years ago
Attachment #8531119 - Attachment is obsolete: true
(Assignee)

Comment 4

3 years ago
Created attachment 8540972 [details] [diff] [review]
Pass through the platform and the tooltool server urls

Give the tooltool server and the platform (so spidermonkey.sh/autospider.sh can distinguish between win32 and win64 builds.)
Attachment #8540972 - Flags: review?(bhearsum)
Attachment #8540972 - Flags: review?(bhearsum) → review+
Attachment #8540971 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/build/buildbotcustom/rev/ef812b5bdee9
https://hg.mozilla.org/build/tools/rev/72c479940cfb

Comment 6

3 years ago
In production: https://hg.mozilla.org/build/buildbotcustom/rev/ef812b5bdee9
(Assignee)

Comment 7

3 years ago
This didn't completely work. I think I'm pulling the tooltool_url_list from the wrong config. Trying out a fix now.
(Assignee)

Comment 8

3 years ago
Created attachment 8552044 [details] [diff] [review]
Use correct config dict for tooltool_url_list

According to my diff, this should do the trick.
Attachment #8552044 - Flags: review?(bhearsum)
(Assignee)

Updated

3 years ago
Blocks: 972089
Attachment #8552044 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 9

3 years ago
https://hg.mozilla.org/build/buildbotcustom/rev/f74d08aada8d
In production: https://hg.mozilla.org/build/buildbotcustom/rev/f74d08aada8d
(In reply to Chris Cooper [:coop] from comment #10)
> In production: https://hg.mozilla.org/build/buildbotcustom/rev/f74d08aada8d

I think this may have caused some spidermonkey-specific bustage, as reported by philor:

https://treeherder.mozilla.org/logviewer.html#?job_id=5771113&repo=mozilla-inbound
(Assignee)

Comment 12

3 years ago
Created attachment 8553143 [details] [diff] [review]
Allow the variant to be mixed in with other params

Argh! Put the arguments out of order. Fix the build script to allow any order.
(Assignee)

Updated

3 years ago
Attachment #8553143 - Flags: review?(bhearsum)

Updated

3 years ago
Attachment #8553143 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 13

3 years ago
https://hg.mozilla.org/build/tools/rev/53d91399c36d
(Assignee)

Comment 14

3 years ago
This is working, finally.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
\o/
You need to log in before you can comment on or make changes to this bug.