1106760 - Consistency in the Rooms expiration date

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Maria Angeles Oteo (:oteo)]

When we create a Room using Firefox Hello in Desktop, the expiration date is set to 56 days (8 weeks). But when we are renaming the room, the expiration date is set to 30 days.

It seems that Desktop is setting the expiration date to 56 days but for renaming the Server is setting it to 30 which seems to be a default value but is not consistent with the Product requirement.

To avoid this, we think it's better using the default expiration time value in server and set it to 56 days, and avoid doing it on client side. So if Product decision changes about this value, we would only need to change it in one place.

Comment 1

[Alexis Metaireau (:alexis)]

I believe this is a dupe of bug 1100556, which will make it to prod with 0.14.0.

Comment 2

[Maria Angeles Oteo (:oteo)]

Reopening, this is not a duplicated.
We need to change this default parameter
 
defaultTTL: {
doc: "The default TTL for a room (in hours)",
format: Number,
default: 24 * 30 // One month.

and it's still set to 30 days

Comment 3

[Mark Banner (:standard8)]

Maria: Please note that for desktop, we're planning on letting the server set the default expiration time (i.e. not specifying it at all from the client). Although I do need to check we've got a couple of bugs on that.

Comment 4

[Maria Angeles Oteo (:oteo)]

(In reply to Mark Banner (:standard8) from comment #3)
> Maria: Please note that for desktop, we're planning on letting the server
> set the default expiration time (i.e. not specifying it at all from the
> client). Although I do need to check we've got a couple of bugs on that.

OK, that's the best solution. In the meantime we have set up the expiration time to 56 days on Mobile Client side but as soon as Server addresses this change we won't indicate explicitly the expiration date  and let the server handle it.

Comment 5

[Alexis Metaireau (:alexis)]

This is now changed. The change will go out with 0.15.0

Comment 6

[Alexis Metaireau (:alexis)]

https://github.com/mozilla-services/loop-server/commit/13c8dc553e0197aa985a316188381e1f43e87e81

Comment 7

[Maria Angeles Oteo (:oteo)]

Checking Bug 1109175 - Please deploy release 0.14.1 to loop-server Stage, it seems that this change will be part of 0.14.1 release.