1107069 - Add contactinfo to RoomsDB schema

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Loop, defect)

Description

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Add contactInfo in roomsDB as we've in converstions [1]

[1] https://github.com/mozilla-b2g/firefoxos-loop-client/blob/master/app/js/screens/calllog.js#L960

Comment 1

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch

Comment 2

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8532046 [details] [review]
Proposed patch

Please check what action db stores:

contactId: [<string>],
contactPrimaryInfo: <string>,
contactPhoto: blob

and the method "_addContactInfoToRecord" in action_log_db. Both logs expect the same fields, basically photo, friendly name and contact id from moz contacts.

Thanks

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Cristian Rodriguez (:crdlc) from comment #2)
> Comment on attachment 8532046 [details] [review]
> Proposed patch
> 
> Please check what action db stores:
> 
> contactId: [<string>],
> contactPrimaryInfo: <string>,
> contactPhoto: blob
> 
> and the method "_addContactInfoToRecord" in action_log_db. Both logs expect
> the same fields, basically photo, friendly name and contact id from moz
> contacts.
> 
> Thanks

Oh, thanks, I've it more clear now :)

Comment 4

[Cristian Rodriguez (:crdlc)]

Comment on attachment 8532046 [details] [review]
Proposed patch

left a comment, thanks a lot for this bug

Comment 5

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/firefoxos-loop-client/commit/e579370030a18652c3a9f6a2f85bd6717d86dd30