1107256 - spell-check underline does not appear in vertical text

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Jonathan Kew [:jfkthame]]

This is because the line is mis-positioned a couple of pixels too far to the left, and falls outside of the clipped drawing area.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Correct the position of text decoration lines on vertical text

Trivial fix; obviously I was thinking backwards when I did this.

Comment 2

[Simon Montagu :smontagu]

Comment on attachment 8531725 [details] [diff] [review]
Correct the position of text decoration lines on vertical text

Review of attachment 8531725 [details] [diff] [review]:
-----------------------------------------------------------------

What about the parallel condition at the end of nsCSSRendering::DecorationLineToPath?

Comment 3

[Jonathan Kew [:jfkthame]]

Attachment: Correct the position of text decoration lines on vertical text

You're right, that needs the same fix - thanks.

Comment 4

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d17bd17b3786

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/15cff727b0d6