1107288 - Always build IGC features into SpiderMonkey

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: always_build_in_incremental-v0.diff

If IGC ever gets disabled in Firefox it would be a catastrophe. Embedders can still disable IGC using DisableIncrementalGC at a negligible runtime cost.

Comment 1

[Andrew McCreight [:mccr8]]

Build changes should probably get a build peer review, even for something trivial looking like this.

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8531749 [details] [diff] [review]
always_build_in_incremental-v0.diff

Review of attachment 8531749 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Terrence Cole [:terrence]]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> Build changes should probably get a build peer review, even for something
> trivial looking like this.

I don't follow. What failure modes exactly are we guarding against by asking a build peer to sign off on this?

Comment 4

[Andrew McCreight [:mccr8]]

(In reply to Terrence Cole [:terrence] from comment #3)
> I don't follow. What failure modes exactly are we guarding against by asking
> a build peer to sign off on this?

I have no idea, I'm not a build peer.

Comment 5

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=e7e1a9509ae7
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/9a7e59858dc6

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9a7e59858dc6