110746 - Image loading prompt improvements

Status: RESOLVED INVALID

(SeaMonkey :: UI Design, defect)

Description

[Hixie (not reading bugmail)]

I would like to suggest we change the image loading prompt dialog to:

   +-- Confirm -----------------------------------------+
   | ...  The site www.foo.com wants to load an image:  |
   |:(?):                                               |
   | '''     http://www.foo.com/images/bar.gif          |
   |                                                    |
   |      Do you want to allow it?                      |
   |                                                    |
   |      [ ] Remember this decision                    |
   |                                                    |
   |         ((Load Image))  (Don't Load Image)         |
   +----------------------------------------------------+

Changes requested in this bug: Add URI of image, change button texts.

Changes *not* requested in this bug: Change question mark icon to image loading
icon, remove title bar text, add period after "remember" text (is this a good
idea?), add "remember for this site" vs "remember for this image", etc.

Note: I am merely filing this on behalf of kiko, although I do agree with the
proposal myself.

mpt: Please check the proposed new spec or pass it to the appropriate UI owner.
 Thanks! :-)

Comment 1

[Christian Reis]

The rationale behind this change is that on sites with many images, we get
identical dialogs popped up continuously, without knowing what image it
specifies. This, however, has been argued against in the cookie pref dialog
(which will be the next target as soon as I've learnt a bit about things here)
bug 23508, so I want mpt to comment on the UI impact. 

If the change involves moving to a disclosure twistie, then I'll need a hand
with the XUL part of it (at least pointing me out to somewhere where it's done
in the codebase is okay).

I'll attach my current patch, which doesn't change the labels on buttons, but
does render out the full image URL.

Comment 2

[Christian Reis]

Attachment: kiko_v1: add image URL to message

I've added the image URL in the middle (will attach screenshot next). I'd like
comments on this because it's my first patch to mozilla and I'm not very
confident of how the code works :-)

mpt can help me out with the UI if he has a minute.

Comment 3

[Christian Reis]

Attachment: screenshot of dialog

Comment 4

[Christian Reis]

CCing mstoltz, morse so they can advise:

To change the button name, (nsPermissions.cpp:77) permission_CheckConfirmYN
would have to pass some parameters to nsIWindowWatcher's ConfirmEx() call. My
question is how should I specify this? Should I pass in the actual button names
into Permission_Check (since it is called by Cookie _and_ Image blocking
functions) or should I do a switch inside it based on a constant?

I can fix this as soon as I understand this part :)

Comment 5

[Matthew T (active 1999-2002)]

Marking invalid, since the image confirmation misfeature has been exorcised.