1107590 - Add entry point to Site Settings from Site Identity popup

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

Now that we're showing the site identity popup for all sites, I think we should look at how we can add site settings/permissions to this popup, which would allow us to get rid of the "Site Settings" menu item.

It would then be cool to build on this in the future with even more help site identity info, such as how much data the page used to load.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to :Margaret Leibovic from comment #0)
> Now that we're showing the site identity popup for all sites

I think this is only on new tablet.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

But actually, I just filed bug 1107591 to always show the site identity popup when hitting the favicon on phones, making this relevant to all devices.

Comment 3

[:Margaret Leibovic]

(In reply to Michael Comella (:mcomella) from comment #2)
> But actually, I just filed bug 1107591 to always show the site identity
> popup when hitting the favicon on phones, making this relevant to all
> devices.

Great, thanks!

Comment 4

[:Margaret Leibovic]

antlam, in the funnel review today we decided to make the site identity popup effort a P1, with a focus on improving our site settings interaction.

If you have time, it would be great to start thinking about what we could do here to increase the visibility of site settings, including giving users an easier way to change these settings (replacing the "Edit site settings" menu item).

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_siteID_update_mock2.png

Definitely! From what I understand, something like this could potentially be a good starting point as well. 

Will keep noodling on this.

Comment 6

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #5)
> Created attachment 8562249 [details]
> prev_siteID_update_mock2.png
> 
> Definitely! From what I understand, something like this could potentially be
> a good starting point as well. 
> 
> Will keep noodling on this.

Ooh, love that simple launch point. This wouldn't be too hard to add, and it would be a nice improvement.

Comment 7

[Chenxia Liu [:liuche]]

Let's get a few more specs on this:

- Title should be favicon + url
- "Secure Connection" instead of "Encrypted"?
- Any other copy changes?

Also:
- What does the non-encrypted version look like?

Can you attach the lock icon resources (and also whatever icon we need for non-encrypted)?

Comment 8

[Chenxia Liu [:liuche]]

Actually, let's simplify this bug so that it's just to add the link to "Edit site settings". We can style the rest of the site settings doorhanger in a different bug - that's scope creeping this bug a lot!

Comment 9

[Chenxia Liu [:liuche]]

Attachment: MozReview Request: bz://1107590/liuche

/r/7409 - Bug 1107590 - Add entry point to Site Settings from Site Identity popup. r=ally

Pull down this commit:

hg pull -r f4e328b35a8dcf0dacb6a6d383c82d66b0c0affd https://reviewboard-hg.mozilla.org/gecko/

Comment 10

[Allison Naaktgeboren :ally]

Comment on attachment 8595588 [details]
MozReview Request: bz://1107590/liuche

https://reviewboard.mozilla.org/r/7407/#review6237

Ship It!

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c9ddb9235baf

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c9ddb9235baf

Comment 13

[Chenxia Liu [:liuche]]

Comment on attachment 8595588 [details]
MozReview Request: bz://1107590/liuche

/r/7409 - Bug 1107590 - Make Site Identity text styling consistent with other doorhangers. r=ally
/r/7443 - Bug 1126608 - Add Doorhanger:Logins message from Gecko. r=ally
/r/8071 - Bug 1126608 - Add "Select" LoginDoorhanger to SiteIdentityPopup. r=ally
/r/8297 - Bug 1126608 - Add buttons. r=ally

Pull down these commits:

hg pull -r 07b2cd024fdbbcd13f991808fce9b27a5723f546 https://reviewboard-hg.mozilla.org/gecko/

Comment 14

[Chenxia Liu [:liuche]]

Comment on attachment 8595588 [details]
MozReview Request: bz://1107590/liuche

I apparently copy-pasted the wrong bug number for the first commit, and now it's forever linked to this bug. I'm going to obsolete this review request, so that it causes less confusion.