add WritingMode to the NotifyIMESelection message

RESOLVED FIXED in mozilla37

Status

()

Core
DOM: Content Processes
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jfkthame, Assigned: jfkthame)

Tracking

(Blocks: 1 bug)

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
The arrow-key remapping patches in bug 1077515 depend on adding a WritingMode to the reply to the NS_QUERY_SELECTED_TEXT event. However, this doesn't work under e10s.

To fix this, we can cache the writing mode on the TabParent at the same time as updating the focus (caret position) via the NotifyIMESelection event.
(Assignee)

Comment 1

3 years ago
Created attachment 8532160 [details] [diff] [review]
Add support for writing-mode to the NotifyIMESelection message
Attachment #8532160 - Flags: review?(bugs)
(Assignee)

Updated

3 years ago
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Attachment #8532160 - Flags: review?(bugs) → review+
Assuming ParamTraits<mozilla::WritingMode> actually does what it tries to (and it should if the code compiles).
Comment on attachment 8532160 [details] [diff] [review]
Add support for writing-mode to the NotifyIMESelection message

Hmm, it is not clear to me why 
WriteParam(aMsg, aParam.mWritingMode); and return ReadParam(aMsg, aIter, &aResult->mWritingMode); actually work.

Why don't you need to read/write the internals of the class
Attachment #8532160 - Flags: review+ → review?(bugs)
Comment on attachment 8532160 [details] [diff] [review]
Add support for writing-mode to the NotifyIMESelection message

Oh, silly me. WritingMode is just a bit odd class, well naming in it is.
WritingMode has member variable mWritingMode.
Attachment #8532160 - Flags: review?(bugs) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b69e830e8e51
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/b69e830e8e51
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.