1107617 - add WritingMode to the NotifyIMESelection message

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Jonathan Kew [:jfkthame]]

The arrow-key remapping patches in bug 1077515 depend on adding a WritingMode to the reply to the NS_QUERY_SELECTED_TEXT event. However, this doesn't work under e10s.

To fix this, we can cache the writing mode on the TabParent at the same time as updating the focus (caret position) via the NotifyIMESelection event.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Add support for writing-mode to the NotifyIMESelection message

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Assuming ParamTraits<mozilla::WritingMode> actually does what it tries to (and it should if the code compiles).

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8532160 [details] [diff] [review]
Add support for writing-mode to the NotifyIMESelection message

Hmm, it is not clear to me why 
WriteParam(aMsg, aParam.mWritingMode); and return ReadParam(aMsg, aIter, &aResult->mWritingMode); actually work.

Why don't you need to read/write the internals of the class

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8532160 [details] [diff] [review]
Add support for writing-mode to the NotifyIMESelection message

Oh, silly me. WritingMode is just a bit odd class, well naming in it is.
WritingMode has member variable mWritingMode.

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b69e830e8e51

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b69e830e8e51