Closed Bug 1107617 Opened 6 years ago Closed 6 years ago
Mode to the Notify IMESelection message
The arrow-key remapping patches in bug 1077515 depend on adding a WritingMode to the reply to the NS_QUERY_SELECTED_TEXT event. However, this doesn't work under e10s. To fix this, we can cache the writing mode on the TabParent at the same time as updating the focus (caret position) via the NotifyIMESelection event.
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assuming ParamTraits<mozilla::WritingMode> actually does what it tries to (and it should if the code compiles).
Comment on attachment 8532160 [details] [diff] [review] Add support for writing-mode to the NotifyIMESelection message Hmm, it is not clear to me why WriteParam(aMsg, aParam.mWritingMode); and return ReadParam(aMsg, aIter, &aResult->mWritingMode); actually work. Why don't you need to read/write the internals of the class
Attachment #8532160 - Flags: review+ → review?(bugs)
Comment on attachment 8532160 [details] [diff] [review] Add support for writing-mode to the NotifyIMESelection message Oh, silly me. WritingMode is just a bit odd class, well naming in it is. WritingMode has member variable mWritingMode.
Target Milestone: --- → mozilla37
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.