1107700 - Improve on the way we trigger the interstitial logout view.

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[Stuart Colville [:muffinresearch]]

Currently we use whether the user didn't come from marketplace *and* if the data-start-view is unset. 

This will break down in a desktop / android setup as we could refresh the page and you will see the logout interstitial.

Let's make the additional check only occur on the page that starts the payment process.

Comment 1

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/spartacus/pull/174
https://github.com/mozilla/webpay/pull/578

Comment 2

[Stuart Colville [:muffinresearch]]

https://github.com/mozilla/webpay/commit/df17fa3466b01b6f5dd4f0bac210aa1f41c37baf
https://github.com/mozilla/spartacus/commit/7904f364bbdf460659ffd820631483209f33d8b6

QA Notes:

We'll need to check this doesn't regress anything around in-app payments. This will require testing in-app with a real purchase to make sure the "You are logged-in as" logout interstitial is only ever seen at the start of the flow when there's an existing session.

Comment 3

[Stuart Colville [:muffinresearch]]

This bug was the previous fix see bug 1107642

Comment 4

[[:AndreiH]]

I tested this manually and it's working fine. This is now Verified and Fixed. Thanks!

Comment 5

[[:AndreiH]]

I tested this manually and it's working fine. This is now Verified and Fixed. Thanks!