1107759 - Support resizing b2g desktop window

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Runtime, defect)

Description

[Alexandre Poirot [:ochameau]]

Today, when we resize b2g desktop, the system app keeps the same size.
Ideally gaia would stretch to the top level window size.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: patch

Fix window resizing and replace dpi support with pixel ratio.
It looks like existing DPI support doesn't do anything...
So instead of keeping a broken feature, let's just make something useful.

Comment 2

[Alexandre Poirot [:ochameau]]

The ratio features allows opening a scaled down TV build with a big resolution:
  b2g-bin --screen 1920x1080@0.25

This features can later be used by simulator profiles to control screen size and pixel ratio from WebIDE.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Alex,

I cannot use this in my mac box. But it works well in my ubuntu box.

Comment 4

[[:fabrice] Fabrice Desré]

Comment on attachment 8532298 [details] [diff] [review]
patch

Review of attachment 8532298 [details] [diff] [review]:
-----------------------------------------------------------------

Works fine for me too on linux. Can you file a follow-up to get the MacOS issue fixed?

Comment 5

[Alexandre Poirot [:ochameau]]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=bc372848c12b

Comment 6

[Alexandre Poirot [:ochameau]]

Actually, while testing on Mac it appeared to me that it is also clunky on Linux,
when the orientation is locked things go wrong. It get reseted to the default screen size with touch even position issues.

Comment 7

[Alexandre Poirot [:ochameau]]

Attachment: patch v2

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=02b2a65f4f72

New patch that watch manual window resizes in order to update width/height attributes in screen.js.
I also added a line:
  GlobalSimulatorScreen.mozOrientation = GlobalSimulatorScreen.screenOrientation = defaultOrientation;
That should help with default orientation being different than portrait.


John, Could you confirm it works better on Mac and also that the default orientation on TV is better handled?

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8537224 [details] [diff] [review]
patch v2

Review of attachment 8537224 [details] [diff] [review]:
-----------------------------------------------------------------

The orientation and resize are working in Mac. Looks pretty good.

I found that I was wrong at comment 3. The resize worked at that time. But I use TV build to test it. The mulet's orientation is wrong and I change the default orientation. While I resized the screen, it only shows partial screen. So, I feel it doesn't work. Sorry about this false alarm.

Comment 9

[Alexandre Poirot [:ochameau]]

Another try, rebased, to see if the failure are really related to this patch:
  https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=3004e88484f6

Comment 10

[Alexandre Poirot [:ochameau]]

Looks like it wasn't...

Comment 11

[Alexandre Poirot [:ochameau]]

I have another patch on top of this one to fix mulet rotation.

Comment 12

[Alexandre Poirot [:ochameau]]

Attachment: Fix mulet

I had to add these two tweaks to get it working nicely also on Mulet...

Comment 13

[Alexandre Poirot [:ochameau]]

Try for the second patch: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2d7b915bff17

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing.

Comment 15

[Alexandre Poirot [:ochameau]]

Attachment: patch v3

Rebased and merged the two patches.

Comment 16

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/integration/b2g-inbound/rev/b9ee124429be

Comment 17

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b9ee124429be