Closed Bug 1107774 Opened 5 years ago Closed 5 years ago

Make LIRGenerator visit() methods infallible

Categories

(Core :: JavaScript Engine: JIT, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: bhackett, Assigned: bhackett)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
Similarly to bug 1106947, during lowering if we encounter an OOM (typically due to running out of virtual registers), the MIR generator can be flagged and the compilation aborted shortly afterwards, rather than requiring explicit error checking throughout the lowering phase.
Attachment #8532318 - Flags: review?(jdemooij)
Comment on attachment 8532318 [details] [diff] [review]
patch

Review of attachment 8532318 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for the delay. Nice cleanup.
Attachment #8532318 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/872df69a912c
Assignee: nobody → bhackett1024
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Depends on: 1116646
You need to log in before you can comment on or make changes to this bug.