1107791 - Limit wildcard DNS ID support to names of the form *.example.com (not foo*.example.com)

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Attachment: remove-unusual-wildcard-support.patch

I've never seen a cert with a name of the form foo*.example.com, but mozilla::pkix supports that name form.

RFC 6125 says such names are valid, but it also says that *foo.example.com and foo*bar.example.com are valid, and we already chose not to support them.

Now, Chromium is limiting its support for wildcards to the *.example.com form. This change is consistent with what they are doing.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Comment on attachment 8532350 [details] [diff] [review]
remove-unusual-wildcard-support.patch

Review of attachment 8532350 [details] [diff] [review]:
-----------------------------------------------------------------

Great - r=me with nit addressed.

::: security/pkix/lib/pkixnames.cpp
@@ +1578,5 @@
> +    if (rv != Success) {
> +      assert(false);
> +      return false;
> +    }
> +    

nit: trailing whitespace

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4530482cc605

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4530482cc605

Comment 4

[Kohei Yoshino [:kohei]]

Added to the compat doc: https://developer.mozilla.org/en-US/Firefox/Releases/37/Site_Compatibility