If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Mark more source directories as FAIL_ON_WARNINGS, some conditionally for just clang or MSVC

RESOLVED FIXED in mozilla37

Status

()

Core
Build Config
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

unspecified
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Created attachment 8532427 [details] [diff] [review]
part-1-unconditional-FAIL_ON_WARNINGS.patch

Part 1: Mark more directories as FAIL_ON_WARNINGS (unconditionally for all compilers)

Green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=08ac647efbcd
(Assignee)

Comment 1

3 years ago
Created attachment 8532428 [details] [diff] [review]
part-2-conditional-FAIL_ON_WARNINGS.patch

Daniel: do you mind testing these FAIL_ON_WARNINGS patches with your Ubuntu clang build environment? Your clang always seems to find problems that our OS X clang does not. :)
Attachment #8532428 - Flags: feedback?(dholbert)
Comment on attachment 8532428 [details] [diff] [review]
part-2-conditional-FAIL_ON_WARNINGS.patch

These don't break anything for me, in my --enable-debug --disable-optimize --enable-warnings-as-errors build. (with clang 3.5 on Ubuntu 14.10)

(I dropped all my other --enable/disable flags to be sure I wasn't turning off any code that's being declared to be warning-free here.)

Thanks!
Attachment #8532428 - Flags: feedback?(dholbert) → feedback+
(Assignee)

Comment 3

3 years ago
Comment on attachment 8532427 [details] [diff] [review]
part-1-unconditional-FAIL_ON_WARNINGS.patch

Part 1: Mark more directories as FAIL_ON_WARNINGS (unconditionally for all compilers)

Green Try build:
https://tbpl.mozilla.org/?tree=Try&rev=08ac647efbcd
Attachment #8532427 - Flags: review?(gps)
(Assignee)

Comment 4

3 years ago
Comment on attachment 8532428 [details] [diff] [review]
part-2-conditional-FAIL_ON_WARNINGS.patch

Part 2: Mark some directories as FAIL_ON_WARNINGS conditionally for some compilers.
Attachment #8532428 - Flags: review?(gps)

Updated

3 years ago
Attachment #8532427 - Flags: review?(gps) → review+

Updated

3 years ago
Attachment #8532428 - Flags: review?(gps) → review+
(Assignee)

Comment 5

3 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b14b9b335d4e
https://hg.mozilla.org/integration/mozilla-inbound/rev/2147895c5dc4
(Assignee)

Comment 6

3 years ago
Back out part of changeset 2147895c5dc4 (bug 1107814) because of non-unified OS X build breakage on a CLOSED TREE. a=philor

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8da0f3cee92
https://hg.mozilla.org/mozilla-central/rev/b14b9b335d4e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.