1107903 - Entry "Open All in Tabs" doesn't appear immediately once a folder gets 2 entries by dragging an item into it (requires closing and reopening the subfolder)

Status: NEW

(Firefox :: Bookmarks & History, defect, P5)

Description

[sworddragon2]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141127104503

Steps to reproduce:

1. Start Firefox, go to the menu bar -> Bookmarks, make a right click at any entry, select "New Folder..." and then click on "Add".
2. Add any page to the bookmarks for example this bug report.
3. Move the bookmarked page into the newly created folder.
4. Add any other page to the bookmarks for example another bug report.
5. Move the bookmarked page into the same folder.


Actual results:

The entry "Open All in Tabs" doesn't appear.


Expected results:

The entry "Open All in Tabs" should appear.

Comment 1

[Loic]

I'm not able to reproduce it with FF34 on Win 7.

Is it specific to the Linux version?

Could you test with a clean profile, please?
https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles

Comment 2

[sworddragon2]

> Is it specific to the Linux version?

I don't know.


> Could you test with a clean profile, please?

This issue appears also on a new profile.

Comment 3

[:Gijs (he/him)]

On my Linux VM, I can reproduce the 'open all in tabs' entry not appearing immediately, but it appears the second time you're opening the folder. Does this match what you're seeing?

If not, that is very strange, because without add-ons, I can't think what'd be interfering with this behaviour to give you different results from me. Are you using an official Mozilla build?

Comment 4

[sworddragon2]

> On my Linux VM, I can reproduce the 'open all in tabs' entry not appearing immediately, but it appears the second time you're opening the folder. Does this match what you're seeing?

Yes, this is what I'm seeing. But I would expect to see the entry "Open All in Tabs" immediately after moving the second bookmark into the folder.

Comment 5

[:Gijs (he/him)]

OK. In that case, this isn't really a particularly serious issue... but maybe Marco could mentor someone who would want to fix it?

Comment 6

[Marco Bonardo [:mak]]

the code handling this is _mayAddCommandsItems in http://mxr.mozilla.org/mozilla-central/source/browser/components/places/content/browserPlacesViews.js (See onPopupShowing), more specificially the hasMultipleURIs var in it.
I'm not sure why it should be different on Linux though, apart we know popups in linux are sometimes buggy (or better out widget code may be).

This is all I can tell for now, I'd have no problem mentoring a patch, but first someone should debug where we fail.

Comment 7

[sworddragon2]

I'm noticing there is also such a problem where a bookmark-submenu does not get completely updated immediately if a superior directory gets sorted while it shows its bookmark-submenu. The position of the directory will change if ordered while his bookmark-submenu will stay at the same position.