1107940 - Remove unused partials from the treeherder-ui repo

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect)

Description

[Jonathan French (:jfrench)]

After doing a bunch of checking in the repo, as far as I can tell, the following two partials are unused:

https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/partials/main/revisionListModal.html

https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/partials/main/thStar.html

And perhaps we keep this below, but for visibility here this is unused at the moment:
https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/partials/main/thSettingsPanel.html

...though there is a placeholder controller
https://github.com/mozilla/treeherder-ui/blob/master/webapp/app/js/controllers/settings.js

Let me know which if any you guys agree should be removed, and I'll remove them.

Comment 1

[Jonathan French (:jfrench)]

I had a chat with camd in channel, he's in agreement so I'll spare Cameron and Ed the request info flags and I will put up a removal PR. We can discuss the Settings partial at that time.

Comment 2

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#293

Please see the above PR for review and status.

If we decide we also want to remove thSettingsPanel, let me know.

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/af41a09b2e614d68f2fc70d052cd07fae9e770b9
Bug 1107940 - Remove unused partials from the repo

https://github.com/mozilla/treeherder-ui/commit/d79c53d31dd968f950c99a2c674a2cd78e969c84
Merge pull request #293 from tojonmz/remove-unused-partials

Bug 1107940 - Remove unused partials from the repo

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8533018 [details] [review]
treeherder-ui-PR#293

Thanks for cleaning these up!  :)

Comment 5

[Jonathan French (:jfrench)]

Verified removed in master per the above commits, and everything still working correctly on stage in the files' absence.

A footnote, I had also gone and checked every other partial in /main to make sure they were actually being used, before making the change. So all that remains (except Settings) is a required partial.

Thanks camd for the review and merge sir! :)

Comment 6

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/485cc296844dade1dc1a1ec2715d5eeda5747594
Bug 1107940 - Remove unused partials from the repo

https://github.com/mozilla/treeherder/commit/f54d77f42fb337e2d5ee8f19d4c756756249e6d3
Merge pull request #293 from tojonmz/remove-unused-partials

Bug 1107940 - Remove unused partials from the repo