110798 - Freeze DOM Event interfaces...

Status: VERIFIED FIXED

(Core :: DOM: Events, defect)

Description

[Chak Nanga]

Freeze the following Event interfaces:

nsIDOMDocumentEvent
nsIDOMEvent
nsIDOMEventListener
nsIDOMEventTarget


Some of these interfaces as they're currently defined differ from the DOM2 specs
as follows:

nsIDOMDocumentEvent:
    * createEvent() method in the spec raises DOMException. Our's does not.

nsIDOMEvent
    * Our definition has the following additional methods which are not in the
DOM2 spec:
     void preventBubble();
     void preventCapture();

nsIDOMEventTarget
    * dispatchEvent() method in the spec raises EventException. Ours does not.

EventException/EventExceptionCode - I did not find any equivalents for these in
our impl.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Make nsIDOMEvent freeze-ready

This patch fixes all the problems I could fid in nsIDOMEvent, with this patch
the interface should match the one defined in the DOM specs. I've already
checked in the missing "raises()" on the trunk to the interfaces mentioned
here. If we want that on the branch we need to move those changes over, but
they have no real impact on the interface so we don't *really* need those
changes on the branch.

Comment 2

[Johnny Stenback (:jst)]

This bug is needed on the 094 branch in order to freeze event API's that are
required by the QCFF team.

Comment 3

[harishd]

Comment on attachment 60308 [details] [diff] [review]
Make nsIDOMEvent freeze-ready

looks good. r=harishd

Comment 4

[Chak Nanga]

Assigning to jst since he's doing most of the work....

Comment 5

[Judson Valeski]

w/ an sr, please checkin to the 0.9.4 branch, and mark keyword field w/
"fixed0.9.4" once it's in.

Comment 6

[John Bandhauer]

Comment on attachment 60308 [details] [diff] [review]
Make nsIDOMEvent freeze-ready

sr=jband.
I trust you tested as appropriate.

Comment 7

[Johnny Stenback (:jst)]

Fix checked in on the trunk, leaving open for landing on the branch too.

Comment 8

[Johnny Stenback (:jst)]

Oh, I also added the comment blocks for actually freezing the interfaces, forgot
to include those in the diffs.

Comment 9

[Johnny Stenback (:jst)]

Fixed on the trunk and on the 094 branch.

Comment 10

[Vladimir Ermakov]

chack: I cant verify this,  could you do it please?

Comment 11

[Chak Nanga]

Verified that the following DOM event interfaces are now frozen(on both the
trunk as well as the 0.9.4 branch):

  nsIDOMDocumentEvent
  nsIDOMEvent
  nsIDOMEventListener
  nsIDOMEventTarget

These interfaces now have the "@status FROZEN" stamp as well as the jst's other
changes from the patch above.