Closed Bug 110798 Opened 23 years ago Closed 23 years ago

Freeze DOM Event interfaces...

Categories

(Core :: DOM: Events, defect)

x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla0.9.7

People

(Reporter: chak, Assigned: jst)

References

Details

(Whiteboard: [HAVE FIX])

Attachments

(1 file)

Freeze the following Event interfaces:

nsIDOMDocumentEvent
nsIDOMEvent
nsIDOMEventListener
nsIDOMEventTarget


Some of these interfaces as they're currently defined differ from the DOM2 specs
as follows:

nsIDOMDocumentEvent:
    * createEvent() method in the spec raises DOMException. Our's does not.

nsIDOMEvent
    * Our definition has the following additional methods which are not in the
DOM2 spec:
     void preventBubble();
     void preventCapture();

nsIDOMEventTarget
    * dispatchEvent() method in the spec raises EventException. Ours does not.

EventException/EventExceptionCode - I did not find any equivalents for these in
our impl.
Blocks: 105444
This patch fixes all the problems I could fid in nsIDOMEvent, with this patch
the interface should match the one defined in the DOM specs. I've already
checked in the missing "raises()" on the trunk to the interfaces mentioned
here. If we want that on the branch we need to move those changes over, but
they have no real impact on the interface so we don't *really* need those
changes on the branch.
This bug is needed on the 094 branch in order to freeze event API's that are
required by the QCFF team.
Keywords: edt0.9.4
Comment on attachment 60308 [details] [diff] [review]
Make nsIDOMEvent freeze-ready

looks good. r=harishd
Attachment #60308 - Flags: review+
Assigning to jst since he's doing most of the work....
Assignee: chak → jst
Status: NEW → ASSIGNED
Whiteboard: [HAVE FIX]
Target Milestone: --- → mozilla0.9.7
w/ an sr, please checkin to the 0.9.4 branch, and mark keyword field w/
"fixed0.9.4" once it's in.
Keywords: edt0.9.4edt0.9.4+
Comment on attachment 60308 [details] [diff] [review]
Make nsIDOMEvent freeze-ready

sr=jband.
I trust you tested as appropriate.
Attachment #60308 - Flags: superreview+
Fix checked in on the trunk, leaving open for landing on the branch too.
Oh, I also added the comment blocks for actually freezing the interfaces, forgot
to include those in the diffs.
Fixed on the trunk and on the 094 branch.
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: fixed0.9.4
Resolution: --- → FIXED
chack: I cant verify this,  could you do it please?
Verified that the following DOM event interfaces are now frozen(on both the
trunk as well as the 0.9.4 branch):

  nsIDOMDocumentEvent
  nsIDOMEvent
  nsIDOMEventListener
  nsIDOMEventTarget

These interfaces now have the "@status FROZEN" stamp as well as the jst's other
changes from the patch above.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.