|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
Created attachment 8532824 [details] screenshot Firefox 34 introduced a new about:home / about:newtab search field styling (bug 1101122 and bug 1101147. You forgot a hidpi friendly version of the icon.
Michael, do we have a hidpi version of this icon?
There's the badly named chrome://global/skin/icons/autocomplete-search.svg#search-icon, which newTab.css in fact already uses for this button when it doesn't have the "magnifier" class: http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/content/newtab/newTab.css#l336
There's already a hi-dpi version of this icon: http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/content/newtab/newTab.css#l357 Why is it not being picked up by the media query?
(In reply to :Felipe Gomes from comment #3) > There's already a hi-dpi version of this icon: > http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/ > content/newtab/newTab.css#l357 > > Why is it not being picked up by the media query? Because the #id of the selector is wrong -- icon instead of logo.
3 years ago
/r/1589 - Bug 1108254 - fix hidpi icon in search, r?felipe Pull down this commit: hg pull review -r 764162314dc48b0a7669ebe41bfe58cd40dca062
Comment on attachment 8538450 [details] MozReview Request: bz://1108254/Gijs Approval Request Comment [Feature/regressing bug #]: bug fx34-searchui [User impact if declined]: sad icon on hidpi [Describe test coverage new/current, TBPL]: nope [Risks and why]: essentially 0, css change to update the ID in a selector so the right image is used [String/UUID change made/needed]: no
Comment on attachment 8538450 [details] MozReview Request: bz://1108254/Gijs
Created attachment 8618820 [details] MozReview Request: Bug 1108254 - fix hidpi icon in search, r?felipe