New about:home/about:newtab search field icon is not hidpi friendly

RESOLVED FIXED in Firefox 35

Status

()

Firefox
Theme
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Sören Hentzschel, Assigned: Gijs)

Tracking

34 Branch
Firefox 37
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify -

Firefox Tracking Flags

(firefox34 wontfix, firefox35 fixed, firefox36 fixed, firefox37 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Created attachment 8532824 [details]
screenshot

Firefox 34 introduced a new about:home / about:newtab search field styling (bug 1101122 and bug 1101147. You forgot a hidpi friendly version of the icon.
Michael, do we have a hidpi version of this icon?
Blocks: 1088660
Points: --- → 3
Flags: qe-verify-
Flags: needinfo?(mmaslaney)
Flags: in-testsuite-
Flags: firefox-backlog+
There's the badly named chrome://global/skin/icons/autocomplete-search.svg#search-icon, which newTab.css in fact already uses for this button when it doesn't have the "magnifier" class:
http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/content/newtab/newTab.css#l336
There's already a hi-dpi version of this icon:
http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/content/newtab/newTab.css#l357

Why is it not being picked up by the media query?
(In reply to :Felipe Gomes from comment #3)
> There's already a hi-dpi version of this icon:
> http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/
> content/newtab/newTab.css#l357
> 
> Why is it not being picked up by the media query?

Because the #id of the selector is wrong -- icon instead of logo.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(mmaslaney)
status-firefox34: --- → wontfix
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
OS: Mac OS X → All
Created attachment 8538450 [details]
MozReview Request: bz://1108254/Gijs
/r/1589 - Bug 1108254 - fix hidpi icon in search, r?felipe

Pull down this commit:

hg pull review -r 764162314dc48b0a7669ebe41bfe58cd40dca062
Attachment #8538450 - Flags: review+
https://reviewboard.mozilla.org/r/1587/#review979

Ship It!
https://hg.mozilla.org/integration/fx-team/rev/84b5923001d6
Comment on attachment 8538450 [details]
MozReview Request: bz://1108254/Gijs

Approval Request Comment
[Feature/regressing bug #]: bug fx34-searchui
[User impact if declined]: sad icon on hidpi
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: essentially 0, css change to update the ID in a selector so the right image is used
[String/UUID change made/needed]: no
Attachment #8538450 - Flags: approval-mozilla-beta?
Attachment #8538450 - Flags: approval-mozilla-aurora?

Updated

3 years ago
Iteration: --- → 37.2
https://hg.mozilla.org/mozilla-central/rev/84b5923001d6
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
status-firefox37: affected → fixed
Attachment #8538450 - Flags: approval-mozilla-beta?
Attachment #8538450 - Flags: approval-mozilla-beta+
Attachment #8538450 - Flags: approval-mozilla-aurora?
Attachment #8538450 - Flags: approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/197b58471fe1
https://hg.mozilla.org/releases/mozilla-beta/rev/2bda8e5c35c1
status-firefox35: affected → fixed
status-firefox36: affected → fixed
Comment on attachment 8538450 [details]
MozReview Request: bz://1108254/Gijs
Attachment #8538450 - Attachment is obsolete: true
Attachment #8618820 - Flags: review+
Created attachment 8618820 [details]
MozReview Request: Bug 1108254 - fix hidpi icon in search, r?felipe
You need to log in before you can comment on or make changes to this bug.