Closed
Bug 1108254
Opened 9 years ago
Closed 9 years ago
New about:home/about:newtab search field icon is not hidpi friendly
Categories
(Firefox :: Theme, defect)
Tracking
()
People
(Reporter: soeren.hentzschel, Assigned: Gijs)
References
Details
Attachments
(2 files, 1 obsolete file)
Firefox 34 introduced a new about:home / about:newtab search field styling (bug 1101122 and bug 1101147. You forgot a hidpi friendly version of the icon.
Assignee | ||
Comment 1•9 years ago
|
||
Michael, do we have a hidpi version of this icon?
Blocks: fx34-searchui
Points: --- → 3
Flags: qe-verify-
Flags: needinfo?(mmaslaney)
Flags: in-testsuite-
Flags: firefox-backlog+
Comment 2•9 years ago
|
||
There's the badly named chrome://global/skin/icons/autocomplete-search.svg#search-icon, which newTab.css in fact already uses for this button when it doesn't have the "magnifier" class: http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/content/newtab/newTab.css#l336
Comment 3•9 years ago
|
||
There's already a hi-dpi version of this icon: http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/content/newtab/newTab.css#l357 Why is it not being picked up by the media query?
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to :Felipe Gomes from comment #3) > There's already a hi-dpi version of this icon: > http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/ > content/newtab/newTab.css#l357 > > Why is it not being picked up by the media query? Because the #id of the selector is wrong -- icon instead of logo.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(mmaslaney)
Assignee | ||
Updated•9 years ago
|
status-firefox34:
--- → wontfix
status-firefox35:
--- → affected
status-firefox36:
--- → affected
status-firefox37:
--- → affected
OS: Mac OS X → All
Assignee | ||
Comment 5•9 years ago
|
||
Assignee | ||
Comment 6•9 years ago
|
||
/r/1589 - Bug 1108254 - fix hidpi icon in search, r?felipe Pull down this commit: hg pull review -r 764162314dc48b0a7669ebe41bfe58cd40dca062
Updated•9 years ago
|
Attachment #8538450 -
Flags: review+
Comment 7•9 years ago
|
||
https://reviewboard.mozilla.org/r/1587/#review979 Ship It!
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/84b5923001d6
Assignee | ||
Comment 9•9 years ago
|
||
Comment on attachment 8538450 [details]
MozReview Request: bz://1108254/Gijs
Approval Request Comment
[Feature/regressing bug #]: bug fx34-searchui
[User impact if declined]: sad icon on hidpi
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: essentially 0, css change to update the ID in a selector so the right image is used
[String/UUID change made/needed]: no
Attachment #8538450 -
Flags: approval-mozilla-beta?
Attachment #8538450 -
Flags: approval-mozilla-aurora?
Updated•9 years ago
|
Iteration: --- → 37.2
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/84b5923001d6
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•9 years ago
|
Updated•9 years ago
|
Attachment #8538450 -
Flags: approval-mozilla-beta?
Attachment #8538450 -
Flags: approval-mozilla-beta+
Attachment #8538450 -
Flags: approval-mozilla-aurora?
Attachment #8538450 -
Flags: approval-mozilla-aurora+
Comment 11•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/197b58471fe1 https://hg.mozilla.org/releases/mozilla-beta/rev/2bda8e5c35c1
Assignee | ||
Comment 12•9 years ago
|
||
Attachment #8538450 -
Attachment is obsolete: true
Attachment #8618820 -
Flags: review+
Assignee | ||
Comment 13•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•