Closed Bug 1108254 Opened 5 years ago Closed 5 years ago

New about:home/about:newtab search field icon is not hidpi friendly

Categories

(Firefox :: Theme, defect)

34 Branch
defect
Not set
Points:
3

Tracking

()

RESOLVED FIXED
Firefox 37
Iteration:
37.2
Tracking Status
firefox34 --- wontfix
firefox35 --- fixed
firefox36 --- fixed
firefox37 --- fixed

People

(Reporter: soeren.hentzschel, Assigned: Gijs)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached image screenshot
Firefox 34 introduced a new about:home / about:newtab search field styling (bug 1101122 and bug 1101147. You forgot a hidpi friendly version of the icon.
Michael, do we have a hidpi version of this icon?
Points: --- → 3
Flags: qe-verify-
Flags: needinfo?(mmaslaney)
Flags: in-testsuite-
Flags: firefox-backlog+
There's the badly named chrome://global/skin/icons/autocomplete-search.svg#search-icon, which newTab.css in fact already uses for this button when it doesn't have the "magnifier" class:
http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/content/newtab/newTab.css#l336
There's already a hi-dpi version of this icon:
http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/content/newtab/newTab.css#l357

Why is it not being picked up by the media query?
(In reply to :Felipe Gomes from comment #3)
> There's already a hi-dpi version of this icon:
> http://hg.mozilla.org/mozilla-central/annotate/0cf461e62ce5/browser/base/
> content/newtab/newTab.css#l357
> 
> Why is it not being picked up by the media query?

Because the #id of the selector is wrong -- icon instead of logo.
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Flags: needinfo?(mmaslaney)
OS: Mac OS X → All
Attached file MozReview Request: bz://1108254/Gijs (obsolete) —
/r/1589 - Bug 1108254 - fix hidpi icon in search, r?felipe

Pull down this commit:

hg pull review -r 764162314dc48b0a7669ebe41bfe58cd40dca062
Comment on attachment 8538450 [details]
MozReview Request: bz://1108254/Gijs

Approval Request Comment
[Feature/regressing bug #]: bug fx34-searchui
[User impact if declined]: sad icon on hidpi
[Describe test coverage new/current, TBPL]: nope
[Risks and why]: essentially 0, css change to update the ID in a selector so the right image is used
[String/UUID change made/needed]: no
Attachment #8538450 - Flags: approval-mozilla-beta?
Attachment #8538450 - Flags: approval-mozilla-aurora?
Iteration: --- → 37.2
https://hg.mozilla.org/mozilla-central/rev/84b5923001d6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Attachment #8538450 - Flags: approval-mozilla-beta?
Attachment #8538450 - Flags: approval-mozilla-beta+
Attachment #8538450 - Flags: approval-mozilla-aurora?
Attachment #8538450 - Flags: approval-mozilla-aurora+
Attachment #8538450 - Attachment is obsolete: true
Attachment #8618820 - Flags: review+
You need to log in before you can comment on or make changes to this bug.