1108275 - Add tests for when the IRC topic is settable.

Status: RESOLVED FIXED

(Chat Core :: IRC, defect)

Description

[Patrick Cloke [:clokep]]

Attachment: irc-test-modes.diff

This adds a couple of tests for setting the mode. It's not exhaustive, but covers when the topic is settable or not.

Comment 1

[aleth [:aleth]]

Comment on attachment 8532838 [details] [diff] [review]
irc-test-modes.diff

Review of attachment 8532838 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/protocols/irc/irc.js
@@ +322,5 @@
>      if (this._participants.has(aNick))
>        return this._participants.get(aNick);
>  
>      let participant = new ircParticipant(aNick, this);
> +    this._participants.set(participant.name, participant);

Why this change? this._participants is a normalizedMap. I would be concerned if the change had any effect.

::: chat/protocols/irc/test/test_setMode.js
@@ +25,5 @@
> +// Test joining a channel, then being set as op.
> +function test_topicSettable() {
> +  let channel = new irc.ircChannel(new FakeAccount(), "#test", "nick");
> +  // We're not in the room yet, so the topic is NOT editable.
> +  equal(channel.topicSettable, false);

It is possible to add the comment explaining the test as a third parameter in equal(), that way it's automatically printed to the log if the test fails, iirc. Worth considering...

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8532838 [details] [diff] [review]
irc-test-modes.diff

(In reply to aleth [:aleth] from comment #1)
> Comment on attachment 8532838 [details] [diff] [review]
> irc-test-modes.diff
> 
> Review of attachment 8532838 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: chat/protocols/irc/irc.js
> @@ +322,5 @@
> >      if (this._participants.has(aNick))
> >        return this._participants.get(aNick);
> >  
> >      let participant = new ircParticipant(aNick, this);
> > +    this._participants.set(participant.name, participant);
> 
> Why this change? this._participants is a normalizedMap. I would be concerned
> if the change had any effect.

Hmm...I think this is a problem with me mocking out the test poorly. I'll look more into this.

Comment 3

[Patrick Cloke [:clokep]]

Attachment: Patch v2

Thanks for pointing out this flaw! I think you'll find the new version better.

Comment 4

[aleth [:aleth]]

Comment on attachment 8533445 [details] [diff] [review]
Patch v2

Review of attachment 8533445 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! :-)

Comment 5

[Patrick Cloke [:clokep]]

https://hg.mozilla.org/comm-central/rev/46b4c8821e79