Closed
Bug 1108294
Opened 5 years ago
Closed 5 years ago
Modernize AccEventGen.py
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Not set
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla37
People
(Reporter: gps, Assigned: gps)
References
(Blocks 1 open bug)
Details
Attachments
(14 files, 2 obsolete files)
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
|
39 bytes,
text/x-review-board-request
|
froydnj
:
review+
|
Details |
AccEventGen.py is using a one-off method for producing .pp files. It is doing so in a manner that causes mozbuild.makeutil.read_deps_file() to break. It is the only broken producer of .pp files AFAICT. Let's just fix AccEventGen.py instead of working around the problem.
|
Assignee | |
Comment 1•5 years ago
|
||
Attachment #8532865 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Comment 2•5 years ago
|
||
/r/1191 - Bug 1108294 - Modernize AccEventGen.py /r/1193 - Bug 1108294 - Removed unused cachedir option /r/1195 - Bug 1108294 - Switch to argparse /r/1197 - Bug 1108294 - Use positional arguments /r/1199 - Bug 1108294 - Use mozbuild.makeutil for dependency file writing /r/1201 - Bug 1108294 - Removed unused makeutils Python module /r/1203 - Bug 1108294 - Remove python/codegen from virtualenv Pull down these commits: hg pull review -r ff02a30aa918cd389627d6c613585ec8e600808c
|
|
Assignee | |
Comment 3•5 years ago
|
||
froydnj: if you want to step in and do code review, go for it :)
|
|
Assignee | |
Comment 4•5 years ago
|
||
Attachment #8532962 -
Flags: review?(mh+mozilla)
|
|
Assignee | |
Comment 5•5 years ago
|
||
/r/1281 - Bug 1108294 - Modernize AccEventGen.py /r/1283 - Bug 1108294 - Removed unused cachedir option /r/1285 - Bug 1108294 - Switch to argparse /r/1287 - Bug 1108294 - Use positional arguments /r/1289 - Bug 1108294 - Use mozbuild.makeutil for dependency file writing /r/1291 - Bug 1108294 - Removed unused makeutils Python module /r/1293 - Bug 1108294 - Remove python/codegen from virtualenv Pull down these commits: hg pull review -r ff02a30aa918cd389627d6c613585ec8e600808c
|
|
Assignee | |
Comment 6•5 years ago
|
||
Comment on attachment 8532865 [details]
MozReview Request: bz://1108294/gps
It appears I found another mozreview bug :/
Attachment #8532865 -
Attachment is obsolete: true
Attachment #8532865 -
Flags: review?(mh+mozilla)
|
||
Comment 7•5 years ago
|
||
(In reply to Gregory Szorc [:gps] from comment #3) > froydnj: if you want to step in and do code review, go for it :) I will do this tomorrow if glandium doesn't beat me to it tonight.
Flags: needinfo?(nfroyd)
|
|
||
Updated•5 years ago
|
Attachment #8532962 -
Flags: review+
|
|
||
Comment 8•5 years ago
|
||
https://reviewboard.mozilla.org/r/1279/#review735 Ship It!
|
|
Assignee | |
Comment 10•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/26b6268a5b18 https://hg.mozilla.org/integration/mozilla-inbound/rev/f85f9a3d6712 https://hg.mozilla.org/integration/mozilla-inbound/rev/3de240f1f86e https://hg.mozilla.org/integration/mozilla-inbound/rev/2662199707fd https://hg.mozilla.org/integration/mozilla-inbound/rev/c9bbb3e155e9 https://hg.mozilla.org/integration/mozilla-inbound/rev/9cbc28021b7b https://hg.mozilla.org/integration/mozilla-inbound/rev/445641aa96c1
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8532962 -
Flags: review?(mh+mozilla)
|
||
Comment 11•5 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/26b6268a5b18 https://hg.mozilla.org/mozilla-central/rev/f85f9a3d6712 https://hg.mozilla.org/mozilla-central/rev/3de240f1f86e https://hg.mozilla.org/mozilla-central/rev/2662199707fd https://hg.mozilla.org/mozilla-central/rev/c9bbb3e155e9 https://hg.mozilla.org/mozilla-central/rev/9cbc28021b7b https://hg.mozilla.org/mozilla-central/rev/445641aa96c1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
|
|
Assignee | |
Comment 12•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8947f95021d
|
|
Assignee | |
Comment 13•4 years ago
|
||
Attachment #8532962 -
Attachment is obsolete: true
Attachment #8618822 -
Flags: review+
Attachment #8618823 -
Flags: review+
Attachment #8618824 -
Flags: review+
Attachment #8618825 -
Flags: review+
Attachment #8618826 -
Flags: review+
Attachment #8618827 -
Flags: review+
Attachment #8618828 -
Flags: review+
Attachment #8618829 -
Flags: review+
Attachment #8618830 -
Flags: review+
Attachment #8618831 -
Flags: review+
Attachment #8618832 -
Flags: review+
Attachment #8618833 -
Flags: review+
Attachment #8618834 -
Flags: review+
Attachment #8618835 -
Flags: review+
|
|
Assignee | |
Comment 14•4 years ago
|
||
|
|
Assignee | |
Comment 15•4 years ago
|
||
|
|
Assignee | |
Comment 16•4 years ago
|
||
|
|
Assignee | |
Comment 17•4 years ago
|
||
|
|
Assignee | |
Comment 18•4 years ago
|
||
|
|
Assignee | |
Comment 19•4 years ago
|
||
|
|
Assignee | |
Comment 20•4 years ago
|
||
|
|
Assignee | |
Comment 21•4 years ago
|
||
|
|
Assignee | |
Comment 22•4 years ago
|
||
|
|
Assignee | |
Comment 23•4 years ago
|
||
|
|
Assignee | |
Comment 24•4 years ago
|
||
|
|
Assignee | |
Comment 25•4 years ago
|
||
|
|
Assignee | |
Comment 26•4 years ago
|
||
|
|
Assignee | |
Comment 27•4 years ago
|
||
|
||
Updated•2 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•