Closed Bug 1108294 Opened 5 years ago Closed 5 years ago

Modernize AccEventGen.py

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37

People

(Reporter: gps, Assigned: gps)

References

(Blocks 1 open bug)

Details

Attachments

(14 files, 2 obsolete files)

39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
39 bytes, text/x-review-board-request
froydnj
: review+
Details
AccEventGen.py is using a one-off method for producing .pp files. It is doing so in a manner that causes mozbuild.makeutil.read_deps_file() to break. It is the only broken producer of .pp files AFAICT. Let's just fix AccEventGen.py instead of working around the problem.
Attached file MozReview Request: bz://1108294/gps (obsolete) —
Attachment #8532865 - Flags: review?(mh+mozilla)
/r/1191 - Bug 1108294 - Modernize AccEventGen.py
/r/1193 - Bug 1108294 - Removed unused cachedir option
/r/1195 - Bug 1108294 - Switch to argparse
/r/1197 - Bug 1108294 - Use positional arguments
/r/1199 - Bug 1108294 - Use mozbuild.makeutil for dependency file writing
/r/1201 - Bug 1108294 - Removed unused makeutils Python module
/r/1203 - Bug 1108294 - Remove python/codegen from virtualenv

Pull down these commits:

hg pull review -r ff02a30aa918cd389627d6c613585ec8e600808c
froydnj: if you want to step in and do code review, go for it :)
Attached file MozReview Request: bz://1108294/gps (obsolete) —
Attachment #8532962 - Flags: review?(mh+mozilla)
/r/1281 - Bug 1108294 - Modernize AccEventGen.py
/r/1283 - Bug 1108294 - Removed unused cachedir option
/r/1285 - Bug 1108294 - Switch to argparse
/r/1287 - Bug 1108294 - Use positional arguments
/r/1289 - Bug 1108294 - Use mozbuild.makeutil for dependency file writing
/r/1291 - Bug 1108294 - Removed unused makeutils Python module
/r/1293 - Bug 1108294 - Remove python/codegen from virtualenv

Pull down these commits:

hg pull review -r ff02a30aa918cd389627d6c613585ec8e600808c
Comment on attachment 8532865 [details]
MozReview Request: bz://1108294/gps

It appears I found another mozreview bug :/
Attachment #8532865 - Attachment is obsolete: true
Attachment #8532865 - Flags: review?(mh+mozilla)
(In reply to Gregory Szorc [:gps] from comment #3)
> froydnj: if you want to step in and do code review, go for it :)

I will do this tomorrow if glandium doesn't beat me to it tonight.
Flags: needinfo?(nfroyd)
Attachment #8532962 - Flags: review+
Whee, reviewboard!
Flags: needinfo?(nfroyd)
Attachment #8532962 - Flags: review?(mh+mozilla)
Attachment #8532962 - Attachment is obsolete: true
Attachment #8618822 - Flags: review+
Attachment #8618823 - Flags: review+
Attachment #8618824 - Flags: review+
Attachment #8618825 - Flags: review+
Attachment #8618826 - Flags: review+
Attachment #8618827 - Flags: review+
Attachment #8618828 - Flags: review+
Attachment #8618829 - Flags: review+
Attachment #8618830 - Flags: review+
Attachment #8618831 - Flags: review+
Attachment #8618832 - Flags: review+
Attachment #8618833 - Flags: review+
Attachment #8618834 - Flags: review+
Attachment #8618835 - Flags: review+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.