1108310 - Remove deprecated for-each-in loop and let blocks and fix strict mode warnings in toolkit/mozapps/downloads

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-downloads-js.patch

1. for-each-in loops and let blocks are a nonstandard JS features of SpiderMonkey and should be removed:

> toolkit/mozapps/downloads/content/downloads.js:414:  let (sb = document.getElementById("downloadStrings")) {
> toolkit/mozapps/downloads/content/downloads.js:976:      let (stateSize = {}) {
> toolkit/mozapps/downloads/content/downloads.js:1113:  let (empty = gDownloadsView.cloneNode(false)) {
> toolkit/mozapps/downloads/content/downloads.js:1175:    let (referrer = gStmt.getString(7)) {

2. Add "use strict" and fix strict mode warnings:

> JavaScript strict warning: resource://gre/modules/DownloadUtils.jsm, line 79: SyntaxError: applying the 'delete' operator to an unqualified name is deprecated
> JavaScript warning: resource://gre/modules/DownloadUtils.jsm, line 273: JavaScript 1.7's let blocks are deprecated

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: fix-webapprt-downloads.patch

Part 2: Remove deprecated for-each-in loop and let blocks and fix strict mode warnings in webapprt/content/downloads/downloads

> webapprt/content/downloads/downloads.js:357:        let (stateSize = {}) {
> webapprt/content/downloads/downloads.js:724:    let (empty = this.downloadView.cloneNode(false)) {
> webapprt/content/downloads/downloads.js:1112:  let (sb = document.getElementById("downloadStrings")) {

Comment 2

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Comment on attachment 8532876 [details] [diff] [review]
fix-downloads-js.patch

Review of attachment 8532876 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/downloads/DownloadUtils.jsm
@@ +277,4 @@
>  
>        // If the new time is similar, reuse something close to the last seconds,
>        // but subtract a little to provide forward progress
> +      diff = aSeconds - aLastSec;

Can just remove this line now.

Comment 3

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f12d02a53b0a
https://hg.mozilla.org/integration/mozilla-inbound/rev/824d26fdcb28

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f12d02a53b0a
https://hg.mozilla.org/mozilla-central/rev/824d26fdcb28

Comment 5

[Marco Castelluccio [:marco]]

This patch caused a regression in webapprt downloads, the patch in bug 1116769 fixes it.

Comment 6

[Marco Castelluccio [:marco]]

(By partially backing out this patch)

Comment 7

[Chris Peterson [:cpeterson]]

Marco's backout:

https://hg.mozilla.org/integration/mozilla-inbound/rev/99dfdc6bdee8