Closed
Bug 110846
Opened 23 years ago
Closed 23 years ago
all nsStandardURL setters except SetSpec are missing the escaping step
Categories
(Core :: Networking, defect, P1)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla0.9.7
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
Attachments
(2 files)
|
10.21 KB,
patch
|
Details | Diff | Splinter Review | |
|
12.93 KB,
patch
|
andreas.otte
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•23 years ago
|
Severity: normal → critical
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla0.9.7
|
||
Comment 1•23 years ago
|
||
We should have a ReplaceSegment and a InsertSegement that do the escaping and
then only use those to manipulate mSpec.
|
|
Assignee | |
Comment 2•23 years ago
|
||
that may not work well, since ReplaceSegment is sometimes called on a fake
segment spanning several segments. i've got a patch almost complete that fixes
this.
|
|
Assignee | |
Comment 3•23 years ago
|
||
|
|
Assignee | |
Comment 4•23 years ago
|
||
*** Bug 110884 has been marked as a duplicate of this bug. ***
|
|
Assignee | |
Comment 5•23 years ago
|
||
andreas: can you review this patch? thx!
|
|
||
Comment 6•23 years ago
|
||
Most of it works fine, SetUsername and SetFilePath do not escape correctly for
the reasons outlined in bug 110500.
|
|
Assignee | |
Comment 7•23 years ago
|
||
andreas: can you r= this? i'm going to also be submitting a JS regression test
script that we can use with xpcshell in a manner similar to urltest before
making future changes to nsStandardURL/nsURLParsers.
|
|
||
Comment 8•23 years ago
|
||
Comment on attachment 58608 [details] [diff] [review]
v1.1 patch: address andreas' concerns
r=andreas.otte@debitel.net
Attachment #58608 -
Flags: review+
|
||
Comment 9•23 years ago
|
||
Comment on attachment 58608 [details] [diff] [review]
v1.1 patch: address andreas' concerns
This seems ok.. not sure I understand 100% of what's going on, but it looks
pretty safe :)
sr=alecf
Attachment #58608 -
Flags: superreview+
|
|
Assignee | |
Comment 10•23 years ago
|
||
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•