1108467 - Implement RegExp.prototype.flags

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Description

[ziyunfei]

js> /foo/yg.flags
"gy"
js> Object.getOwnPropertyDescriptor(RegExp.prototype,"flags").get.call({sticky:1,unicode:1})
"yu"

Comment 1

[ziyunfei]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/flags

Comment 2

[ziyunfei]

Attachment: bug-1108467-v1.patch

Comment 3

[Till Schneidereit [:till]]

Comment on attachment 8533163 [details] [diff] [review]
bug-1108467-v1.patch

Review of attachment 8533163 [details] [diff] [review]:
-----------------------------------------------------------------

This looks excellent, thanks!

r=me with feedback addressed.

::: js/src/tests/ecma_6/RegExp/flags.js
@@ +1,3 @@
> +/*
> + * Any copyright is dedicated to the Public Domain.
> + * http://creativecommons.org/licenses/publicdomain/

You can just leave out the license header: all test files default to CC0. If you keep it, please change the URL to https://creativecommons.org/publicdomain/zero/1.0/.

@@ +10,5 @@
> +
> +assertEq(RegExp.prototype.flags, "");
> +assertEq(/foo/iymg.flags, "gimy");
> +assertEq(RegExp("").flags, "");
> +assertEq(RegExp("", "mygi").flags, "gimy");

Please add a test that includes "u" when creating a regexp but doesn't reflect it in the `flags` getter. That way, we should get a heads-up once we add support for unicode regexps.

Comment 4

[ziyunfei]

Attachment: feedback addressed

Comment 5

[ziyunfei]

Comment on attachment 8533470 [details] [diff] [review]
feedback addressed

Review of attachment 8533470 [details] [diff] [review]:
-----------------------------------------------------------------

https://bugs.ecmascript.org/show_bug.cgi?id=3423

Comment 6

[ziyunfei]

Attachment: s/gimyu/gimuy/

Comment 7

[Till Schneidereit [:till]]

Comment on attachment 8533506 [details] [diff] [review]
s/gimyu/gimuy/

Review of attachment 8533506 [details] [diff] [review]:
-----------------------------------------------------------------

Wonderful.

It occurs to me just now that we might as well have self-hosted this. Too late now, though, so let's just land it.

Comment 8

[ziyunfei]

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8673d6ad8ae8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc5ad20e8f27

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc5ad20e8f27