1108548 - Loop: Setting loop.enabled to false causes widget/node not found error

Status: RESOLVED WORKSFORME

(Hello (Loop) :: General, defect)

Description

[Aris]

Attachment: loop_disabled_error.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20141201162954

Steps to reproduce:

Go to about:config using Firefox 34-37 on any OS (Windows, Linux, MacOSX).
Search for 'loop.enabled' and set it to 'false'.
Restart Firefox.


Actual results:

Loop functionality and loop button got removed like they should, bug the browser console now shows the error:
Fx35: "[CustomizableUI]" "Custom widget with id loop-button-throttled does not return a valid node".
Fx37: "[CustomizableUI]" "Custom widget with id loop-button does not return a valid node"



Expected results:

Checks for "loop-button-throttled" item/node should not be made once loop functionality gets disabled.

Comment 1

[u279076]

Apart from an error in console, is there any user-facing impact?

Comment 2

[Aris]

The error message in console is the only issue. No 'visible' problems besides that.

Comment 3

[u279076]

Okay, thanks.

Comment 4

[:shell escalante]

there's a do not disturb option - not a user exposed preference. going forward we'll be fixing anything

Comment 5

[Mark Banner (:standard8)]

Arthur, please can you explain why you have re-opened this?

It is something we've explicitly decided to wontfix, especially given the fact its an error in the console that doesn't affect users (admittedly comment 4 is a bit vague, comments 1 to 3 are more relevant here).

However, I think you'll also find that it is fixed in 45 & later because we changed how our startup process is working.

Comment 6

[Aris]

I can confirm that. Even if it was marked as WONTFIX, it got fixed in Fx45+ because of all loop related changes.

Comment 7

[Arthur Edelstein [:arthur]]

Mark and Aris, I think you're right. Sorry for the noise.