Closed
Bug 1108548
Opened 10 years ago
Closed 9 years ago
Loop: Setting loop.enabled to false causes widget/node not found error
Categories
(Hello (Loop) :: General, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: aris-addons, Unassigned)
References
Details
(Whiteboard: [tor])
Attachments
(1 file)
19.66 KB,
image/png
|
Details |
User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:35.0) Gecko/20100101 Firefox/35.0
Build ID: 20141201162954
Steps to reproduce:
Go to about:config using Firefox 34-37 on any OS (Windows, Linux, MacOSX).
Search for 'loop.enabled' and set it to 'false'.
Restart Firefox.
Actual results:
Loop functionality and loop button got removed like they should, bug the browser console now shows the error:
Fx35: "[CustomizableUI]" "Custom widget with id loop-button-throttled does not return a valid node".
Fx37: "[CustomizableUI]" "Custom widget with id loop-button does not return a valid node"
Expected results:
Checks for "loop-button-throttled" item/node should not be made once loop functionality gets disabled.
Updated•10 years ago
|
Component: Untriaged → General
Product: Firefox → Loop
QA Contact: anthony.s.hughes
Version: 35 Branch → unspecified
The error message in console is the only issue. No 'visible' problems besides that.
Comment 4•10 years ago
|
||
there's a do not disturb option - not a user exposed preference. going forward we'll be fixing anything
Status: UNCONFIRMED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
Updated•9 years ago
|
Whiteboard: [tor]
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: WONTFIX → ---
Comment 5•9 years ago
|
||
Arthur, please can you explain why you have re-opened this?
It is something we've explicitly decided to wontfix, especially given the fact its an error in the console that doesn't affect users (admittedly comment 4 is a bit vague, comments 1 to 3 are more relevant here).
However, I think you'll also find that it is fixed in 45 & later because we changed how our startup process is working.
Flags: needinfo?(arthuredelstein)
QA Contact: anthony.s.hughes
I can confirm that. Even if it was marked as WONTFIX, it got fixed in Fx45+ because of all loop related changes.
Updated•9 years ago
|
Status: REOPENED → RESOLVED
Closed: 10 years ago → 9 years ago
Resolution: --- → WORKSFORME
Comment 7•9 years ago
|
||
Mark and Aris, I think you're right. Sorry for the noise.
Flags: needinfo?(arthuredelstein)
You need to log in
before you can comment on or make changes to this bug.
Description
•