bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

describecomponents.cgi?product=X shouldn't list default assignee if it's "nobody"

RESOLVED FIXED

Status

()

bugzilla.mozilla.org
User Interface
--
enhancement
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Gijs, Assigned: dkl)

Tracking

Production

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

4 years ago
https://bugzilla.mozilla.org/describecomponents.cgi?product=Core

Find bar says 100+ matches for " Nobody; OK to take it and work on it ".

Let's not do that.

(not sure if that's a bmo or Bugzilla thing to fix, might be harder to do in the general case?)
(Assignee)

Comment 1

4 years ago
An assignee for a component in Bugzilla is mandatory so BMO uses a dummy account called nobody@mozilla.org to fill that requirement. The describe components page is just displaying whatever is stored in the database. So we will need to make a customization to the BMO code itself to hide the assignee value if equal to nobody@mozilla.org.

dkl
Assignee: ui → nobody
Severity: normal → enhancement
Component: User Interface → User Interface
Product: Bugzilla → bugzilla.mozilla.org
QA Contact: default-qa
Version: unspecified → Production

Comment 2

4 years ago
What's the actual problem with the curent behavior?
The only problem 'description' I see is "Let's not do that." without any arguments.
(Reporter)

Comment 3

4 years ago
(In reply to Andre Klapper from comment #2)
> What's the actual problem with the curent behavior?

It's repetitive, uninformative, and needlessly takes up space. Knowing that bugs there are by default not assigned to anybody doesn't help, err, anybody. We should just not display it at all unless the assignee is non-empty, so to speak, as 'empty' is what nobody@mozilla.org stands for (see comment #1).

In essence, my argument is that it's about as useful as padding out the descriptions with an extra line saying "mozilla is awesome" for every description. Correct information, but doesn't add anything to the page, and wastes space - so we should get rid of it.
(Assignee)

Updated

4 years ago
Assignee: nobody → dkl
Status: NEW → ASSIGNED
(Assignee)

Comment 4

4 years ago
Created attachment 8533906 [details] [diff] [review]
1108685_1.patch

I agree that this is possibly low priority, but being that it was a small change to implement, I am putting it up for review/feedback anyway.
Attachment #8533906 - Flags: review?(glob)
Comment on attachment 8533906 [details] [diff] [review]
1108685_1.patch

Review of attachment 8533906 [details] [diff] [review]:
-----------------------------------------------------------------

if we're to do this correctly, we should also be skipping *.bugs default owners (mostly for the bugzilla and infra products).

however i don't think showing the default assignee and qa-contact on this page provides any value.
instead of selectively removing values, let's remove both those fields completely.
Attachment #8533906 - Flags: review?(glob) → review-
(Assignee)

Comment 6

4 years ago
Created attachment 8545410 [details] [diff] [review]
1108685_2.patch

Ok. So I took a different approach.
Attachment #8533906 - Attachment is obsolete: true
Attachment #8545410 - Flags: review?(glob)
Comment on attachment 8545410 [details] [diff] [review]
1108685_2.patch

Review of attachment 8545410 [details] [diff] [review]:
-----------------------------------------------------------------

this looks awesome, r=glob

::: extensions/BMO/template/en/default/reports/components.html.tmpl
@@ +16,5 @@
> +  # Rights Reserved.
> +  #
> +  # Contributor(s): Bradley Baetz <bbaetz@student.usyd.edu.au>
> +  #                 Max Kanat-Alexander <mkanat@bugzilla.org>
> +  #%]

change this license please

@@ +39,5 @@
> +  font-weight: normal;
> +}
> +.product_desc, .component_desc {
> +  padding-left: 1em;
> +  font-size: 1em;

i suggest setting max-height:none here.
Attachment #8545410 - Flags: review?(glob) → review+
(Assignee)

Comment 8

4 years ago
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   0ed20de..570476d  master -> master
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

4 years ago
This is live now
You need to log in before you can comment on or make changes to this bug.