1108829 - Pinboard should be closed after classifications are saved.

Status: NEW

(Tree Management :: Treeherder, defect, P3)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Unsure if something on stage or dev would fix this already, but on production, if I select a failure, pin a suggested bug, and click "Save", Treeherder deviates from what I feel should happen.

At the moment, when the Save button is clicked, it clears the pinboard's fields, but the pinboard itself stays open. Even if I click close the bottom panel (by clicking the 'X' or a blank part of the page), the pinboard is still open automatically the next time I select a job/failure. This makes it harder to read the job metadata in the left side of the bottom panel, since the height is reduced.

In my perfect world, clicking "Save" would clear all of the pinboard fields (like it currently does), then close the pinboard, returning the bottom panel to its full height. The saved details will appear in the left side of the bottom panel (with links to the bugs, etc).

Comment 1

[Ed Morley [:emorley]]

I'm pretty sure this was deliberately changed like this, to avoid the disjointed UX of the board constantly opening and closing as people pressed the j/k keys and classified using the pin next to a failure suggestion.

That said I think we can improve the UX quite a bit - for the "single job selected, have a bug suggestion" case, we almost don't even need to open the pinboard.