[B2G][Followup-873351] replace the prefix of gonk-backend services from "ril" to "gonk" in mobile message

RESOLVED FIXED in 2.2 S3 (9jan)

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: bevis, Assigned: bevis)

Tracking

unspecified
2.2 S3 (9jan)
ARM
Gonk (Firefox OS)
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(feature-b2g:2.2+, tracking-b2g:backlog)

Details

Attachments

(2 attachments, 2 obsolete attachments)

This is a followup of bug 873351.

We now have naming convention of Gonk-Backend Services with "Gonk" as the prefix of its contractID but was not followed by mobilemessage which has been created before this convention defined.

File this bug to rename |@mozilla.org/mms/rilmmsservice;1| of MmsService.js and |@mozilla.org/mobilemessage/rilmobilemessagedatabaseservice;1| of MobileMessageDatabaseService.js to |@mozilla.org/mms/gonkmmsservice;1| and |@mozilla.org/mobilemessage/gonkmobilemessagedatabaseservice;1|
(Assignee)

Updated

4 years ago
Summary: [B2G][Followup-873351] replace the prefix of gonk-backend services from "ril" to "gonk" → [B2G][Followup-873351] replace the prefix of gonk-backend services from "ril" to "gonk" in mobile message
(Assignee)

Comment 1

4 years ago
MobileMessageDatabaseService.js will be used by SmsService.js after bug 873351 is included.
If SmsService.js will be overridden by vendor, we have to include this fix for v2.2 as well.
Blocks: 959978
blocking-b2g: --- → 2.2?
(Assignee)

Comment 2

4 years ago
Created attachment 8534207 [details] [diff] [review]
Part 1 v1: rename MobileMessageDatabaseService. r=echen

Hi Edgar,

May I have your review for this change?

Thanks!
Attachment #8534207 - Flags: review?(echen)
(Assignee)

Comment 3

4 years ago
Created attachment 8534210 [details] [diff] [review]
Part 2 v1: rename MmsService. r=echen

Hi Edgar,

May I have your review for this change?

Thanks!
Attachment #8534210 - Flags: review?(echen)
triage: this is follow up feature, so changing flag to feature-b2g.
blocking-b2g: 2.2? → backlog
feature-b2g: --- → 2.2+

Comment 5

4 years ago
Comment on attachment 8534207 [details] [diff] [review]
Part 1 v1: rename MobileMessageDatabaseService. r=echen

Review of attachment 8534207 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.
Attachment #8534207 - Flags: review?(echen) → review+

Comment 6

4 years ago
Comment on attachment 8534210 [details] [diff] [review]
Part 2 v1: rename MmsService. r=echen

Review of attachment 8534210 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Thank you.

::: dom/mobilemessage/gonk/MmsService.js
@@ +13,5 @@
>  Cu.import("resource://gre/modules/PhoneNumberUtils.jsm");
>  Cu.import("resource://gre/modules/Promise.jsm");
>  
> +const GONK_MMSSERVICE_CONTRACTID = "@mozilla.org/mms/gonkmmsservice;1";
> +const GONK_MMSSERVICE_CID = Components.ID("{217ddd76-75db-4210-955d-8806cd8d87f9}");

Since the contract id is changed, I suggest having an UUID bump for it.

::: dom/mobilemessage/gonk/MmsService.manifest
@@ +1,3 @@
>  # MmsService.js
>  component {217ddd76-75db-4210-955d-8806cd8d87f9} MmsService.js
> +contract @mozilla.org/mms/gonkmmsservice;1 {217ddd76-75db-4210-955d-8806cd8d87f9}

Ditto
Attachment #8534210 - Flags: review?(echen) → review+
(Assignee)

Comment 7

4 years ago
(In reply to Edgar Chen [:edgar][:echen] from comment #6)
> Comment on attachment 8534210 [details] [diff] [review]
> Part 2 v1: rename MmsService. r=echen
> 
> Review of attachment 8534210 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with comment addressed. Thank you.
> 
> ::: dom/mobilemessage/gonk/MmsService.js
> @@ +13,5 @@
> >  Cu.import("resource://gre/modules/PhoneNumberUtils.jsm");
> >  Cu.import("resource://gre/modules/Promise.jsm");
> >  
> > +const GONK_MMSSERVICE_CONTRACTID = "@mozilla.org/mms/gonkmmsservice;1";
> > +const GONK_MMSSERVICE_CID = Components.ID("{217ddd76-75db-4210-955d-8806cd8d87f9}");
> 
> Since the contract id is changed, I suggest having an UUID bump for it.
> 
> ::: dom/mobilemessage/gonk/MmsService.manifest
> @@ +1,3 @@
> >  # MmsService.js
> >  component {217ddd76-75db-4210-955d-8806cd8d87f9} MmsService.js
> > +contract @mozilla.org/mms/gonkmmsservice;1 {217ddd76-75db-4210-955d-8806cd8d87f9}
> 
> Ditto

Opps!
Thank for reminding! I think I missed the change in part 2. :(
(Assignee)

Comment 8

4 years ago
Created attachment 8539055 [details] [diff] [review]
Part 1: rename MobileMessageDatabaseService. r=echen

Update final patch with positive try server result.
Attachment #8534207 - Attachment is obsolete: true
Attachment #8539055 - Flags: review+
(Assignee)

Comment 9

4 years ago
Created attachment 8539056 [details] [diff] [review]
Part 2: rename MmsService. r=echen

Address comment comment 6.
Attachment #8534210 - Attachment is obsolete: true
Attachment #8539056 - Flags: review+
Update try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea1de9f98a39
Keywords: checkin-needed
(Assignee)

Updated

4 years ago
Depends on: 873351

Updated

4 years ago
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/45e6036c278a
https://hg.mozilla.org/mozilla-central/rev/15894c19ddd6
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S3 (9jan)
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.