1108900 - [B2G][Followup-873351] replace the prefix of gonk-backend services from "ril" to "gonk" in mobile message

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

This is a followup of bug 873351.

We now have naming convention of Gonk-Backend Services with "Gonk" as the prefix of its contractID but was not followed by mobilemessage which has been created before this convention defined.

File this bug to rename |@mozilla.org/mms/rilmmsservice;1| of MmsService.js and |@mozilla.org/mobilemessage/rilmobilemessagedatabaseservice;1| of MobileMessageDatabaseService.js to |@mozilla.org/mms/gonkmmsservice;1| and |@mozilla.org/mobilemessage/gonkmobilemessagedatabaseservice;1|

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

MobileMessageDatabaseService.js will be used by SmsService.js after bug 873351 is included.
If SmsService.js will be overridden by vendor, we have to include this fix for v2.2 as well.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Part 1 v1: rename MobileMessageDatabaseService. r=echen

Hi Edgar,

May I have your review for this change?

Thanks!

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Part 2 v1: rename MmsService. r=echen

Hi Edgar,

May I have your review for this change?

Thanks!

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: this is follow up feature, so changing flag to feature-b2g.

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 8534207 [details] [diff] [review]
Part 1 v1: rename MobileMessageDatabaseService. r=echen

Review of attachment 8534207 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.

Comment 6

[Edgar Chen [:edgar]]

Comment on attachment 8534210 [details] [diff] [review]
Part 2 v1: rename MmsService. r=echen

Review of attachment 8534210 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed. Thank you.

::: dom/mobilemessage/gonk/MmsService.js
@@ +13,5 @@
>  Cu.import("resource://gre/modules/PhoneNumberUtils.jsm");
>  Cu.import("resource://gre/modules/Promise.jsm");
>  
> +const GONK_MMSSERVICE_CONTRACTID = "@mozilla.org/mms/gonkmmsservice;1";
> +const GONK_MMSSERVICE_CID = Components.ID("{217ddd76-75db-4210-955d-8806cd8d87f9}");

Since the contract id is changed, I suggest having an UUID bump for it.

::: dom/mobilemessage/gonk/MmsService.manifest
@@ +1,3 @@
>  # MmsService.js
>  component {217ddd76-75db-4210-955d-8806cd8d87f9} MmsService.js
> +contract @mozilla.org/mms/gonkmmsservice;1 {217ddd76-75db-4210-955d-8806cd8d87f9}

Ditto

Comment 7

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Edgar Chen [:edgar][:echen] from comment #6)
> Comment on attachment 8534210 [details] [diff] [review]
> Part 2 v1: rename MmsService. r=echen
> 
> Review of attachment 8534210 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r=me with comment addressed. Thank you.
> 
> ::: dom/mobilemessage/gonk/MmsService.js
> @@ +13,5 @@
> >  Cu.import("resource://gre/modules/PhoneNumberUtils.jsm");
> >  Cu.import("resource://gre/modules/Promise.jsm");
> >  
> > +const GONK_MMSSERVICE_CONTRACTID = "@mozilla.org/mms/gonkmmsservice;1";
> > +const GONK_MMSSERVICE_CID = Components.ID("{217ddd76-75db-4210-955d-8806cd8d87f9}");
> 
> Since the contract id is changed, I suggest having an UUID bump for it.
> 
> ::: dom/mobilemessage/gonk/MmsService.manifest
> @@ +1,3 @@
> >  # MmsService.js
> >  component {217ddd76-75db-4210-955d-8806cd8d87f9} MmsService.js
> > +contract @mozilla.org/mms/gonkmmsservice;1 {217ddd76-75db-4210-955d-8806cd8d87f9}
> 
> Ditto

Opps!
Thank for reminding! I think I missed the change in part 2. :(

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Part 1: rename MobileMessageDatabaseService. r=echen

Update final patch with positive try server result.

Comment 9

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: Part 2: rename MmsService. r=echen

Address comment comment 6.

Comment 10

[Bevis Tseng[:bevis][:btseng](Exited)]

Update try server result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea1de9f98a39

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/45e6036c278a
https://hg.mozilla.org/integration/b2g-inbound/rev/15894c19ddd6

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/45e6036c278a
https://hg.mozilla.org/mozilla-central/rev/15894c19ddd6