1108965 - Call Set constructor with "new".

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Input Mgmt, defect)

Description

[Tooru Fujisawa [:arai]]

(derived from bug 1108930)

Before fixing bug 1062075 and bug 1083752,
we need to add "new" to all Map/Set/WeakMap constructor calls.
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=08a0908f8706

http://mxr.mozilla.org/gaia/source/apps/system/js/input_layouts.js#176
>     this._enabledApps = Set();

http://mxr.mozilla.org/gaia/source/apps/system/test/unit/input_layouts_test.js#93
>     inputLayouts._enabledApps = Set();

http://mxr.mozilla.org/gaia/source/apps/system/test/unit/input_layouts_test.js#130
>     inputLayouts._enabledApps = Set();

http://mxr.mozilla.org/gaia/source/tv_apps/smart-system/js/input_layouts.js#176
>     this._enabledApps = Set();

Comment 1

[Tooru Fujisawa [:arai]]

running try: https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=8f3b97f5c3ae

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Call Set constructor with new.

Added "new" to Set() calls in comment #0

Try in comment #1 was almost green, except B2G ICS Emulator opt Mn and Mnw,
which uses non-patched gaia branch, so I guess it will be fixed after this patch is landed.

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8534130 [details] [review]
Call Set constructor with new.

Thanks!

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

master: https://github.com/mozilla-b2g/gaia/commit/e17c5656dbf517d48fb61ac9bc92119e023fd717

Comment 5

[Tooru Fujisawa [:arai]]

Thank you for reviewing and merging :)
Confirmed that the error in Mn and Mnw are fixed by this patch.
  https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2063bee5e775