Closed
Bug 1108975
Opened 10 years ago
Closed 10 years ago
[Loop] Change the way the tests are invoked
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: amac, Assigned: amac)
References
Details
Attachments
(1 file)
The current way to add tests (adding them to index.template.html) has a couple of problems:
a) It doesn't work correctly. The translation from the template to the test file loads a bunch of JS that aren't really loaded because they're not shared on the path they're being loaded.
b) It doesn't really lend itself to write unit tests (since if it worked it would load all the original JS, making every test a integration one).
So a new way is needed to make adding new, independent tests, easy.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8533624 -
Flags: review?(crdlc)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8533624 [details] [review]
V1. Change the test infrastructure (no new tests added yet)
Good job, left a comment/question, thanks a lot
Attachment #8533624 -
Flags: review?(crdlc) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Good catch :) I updated the PR, can you checkin it?
|
|
Assignee | |
Comment 4•10 years ago
|
||
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/50e68858928322d0ab296530620969b7cff31630
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•