Closed
Bug 1109000
Opened 10 years ago
Closed 10 years ago
Refactor statics out of BrowserLocaleManager
Categories
(Firefox for Android Graveyard :: Locale switching and selection, defect)
Firefox for Android Graveyard
Locale switching and selection
All
Android
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
|
45.69 KB,
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•10 years ago
|
||
Corresponding pull request:
https://github.com/mozilla-services/android-sync/pull/510
Attachment #8533660 -
Flags: review?(nalexander)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8533660 [details] [diff] [review]
Split statics out of BrowserLocaleManager. v1
Review of attachment 8533660 [details] [diff] [review]:
-----------------------------------------------------------------
I have no problem with this.
Attachment #8533660 -
Flags: review?(nalexander) → review+
|
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8533660 [details] [diff] [review]
Split statics out of BrowserLocaleManager. v1
Review of attachment 8533660 [details] [diff] [review]:
-----------------------------------------------------------------
::: mobile/android/base/Locales.java
@@ +15,5 @@
> import android.os.StrictMode;
> import android.support.v4.app.FragmentActivity;
>
> /**
> + * This is a helper class to do typical locale switching operations without
There are some trailing whitespace issues throughout here, but nbd.
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•