1109000 - Refactor statics out of BrowserLocaleManager

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Locale switching and selection, defect)

Comment 1

[Richard Newman [:rnewman]]

Attachment: Split statics out of BrowserLocaleManager. v1

Corresponding pull request:

https://github.com/mozilla-services/android-sync/pull/510

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8533660 [details] [diff] [review]
Split statics out of BrowserLocaleManager. v1

Review of attachment 8533660 [details] [diff] [review]:
-----------------------------------------------------------------

I have no problem with this.

Comment 3

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8533660 [details] [diff] [review]
Split statics out of BrowserLocaleManager. v1

Review of attachment 8533660 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/Locales.java
@@ +15,5 @@
>  import android.os.StrictMode;
>  import android.support.v4.app.FragmentActivity;
>  
>  /**
> + * This is a helper class to do typical locale switching operations without

There are some trailing whitespace issues throughout here, but nbd.

Comment 4

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/e2759f8d7232

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e2759f8d7232