1109121 - Internal server error when censoring demo studio demos

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

What did you do?
================
1. in admin panel https://developer.mozilla.org/admin/demos/submission, search for a demo you wish to censor
2. select the demo with the checkbox on the far left
3. in the dropdown at the bottom left of the page, choose "censor selected submissions"
4. this will automatically post a request; the response will be an internal server error
5. force refreshing the listing page (without posting) will show that the demo is not censored

What happened?
==============
An internal server error.

What should have happened?
==========================
The selected demos should have been censored.

Is there anything else we should know?
======================================
From IRC:

[08:52:46]  <@jezdez> https://github.com/mozilla/kuma/blob/e6fcb166aa1e357949b9caed277e6648c7544b4e/kuma/demos/admin.py#L55 is what blows up
[08:52:56]  <@jezdez>	that value doesn’t exist anymore
[08:54:42]  <@jezdez>	hoosteeno: that variable is not even used anymore
[08:54:44]  <@jezdez>	in the template
[08:54:55]  <@jezdez>	so a left-over from django 1.2 times
[08:55:04]  <@jezdez>	easy to fix, in other words

Comment 1

[MDN Team (:mdn-dev)]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/22a58db50f78a5cbbce5c6e03d1900e0297c85bd
Fix bug 1109121 - update custom admin actions.

This updates the censor and delete admin actions in the demos app to match the one in Django 1.4.

https://github.com/mozilla/kuma/commit/be79e7685a80b112b29acf6783c949fd322f4256
Refs bug #1109121 - Join path in demos app correctly.

Instead of using string substituation we should be using os.path.join.

https://github.com/mozilla/kuma/commit/f9393885f3210020217412039830bab7ea268d20
Merge pull request #2942 from jezdez/bug1109121

Fix bug 1109121 -- fix censor admin action.