Closed Bug 1109130 Opened 10 years ago Closed 10 years ago

Build bustage in SdpAttribute.h with older MSVC compilers

Categories

(Core :: WebRTC: Signaling, defect)

Product:
Core
Component:
WebRTC: Signaling
Platform:
x86
Windows 8.1
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: RyanVM, Assigned: bwc)

References

Details

Attachments

(1 file, 3 obsolete files)

Give MSVC2012 a hint about what these aggregate initializers mean.
8.66 KB, patch
jesup
: review+
Details | Diff | Splinter Review 
I'm hitting this locally with MSVC2012. I'm told on IRC that it affects MSVC2010 as well.

Sorry for the crappy mach log output.

[1418140917.166, "build_output", {"line": "c:\\Users\\Ryan\\repos\\mozilla-central\\media\\webrtc\\signaling/src/sdp/SdpAttribute.h(259) : error C2143: syntax error : missing ')' before '{'"}]
[1418140917.17, "build_output", {"line": "c:\\Users\\Ryan\\repos\\mozilla-central\\media\\webrtc\\signaling/src/sdp/SdpAttribute.h(259) : error C2661: 'std::vector<_Ty>::push_back' : no overloaded function takes 0 arguments"}]
[1418140917.175, "build_output", {"line": "        with"}]
[1418140917.176, "build_output", {"line": "        ["}]
[1418140917.178, "build_output", {"line": "            _Ty=mozilla::SdpExtmapAttributeList::Extmap"}]
[1418140917.179, "build_output", {"line": "        ]"}]
[1418140917.183, "build_output", {"line": "c:\\Users\\Ryan\\repos\\mozilla-central\\media\\webrtc\\signaling/src/sdp/SdpAttribute.h(259) : error C2143: syntax error : missing ';' before '{'"}]
[1418140917.185, "build_output", {"line": "c:\\Users\\Ryan\\repos\\mozilla-central\\media\\webrtc\\signaling/src/sdp/SdpAttribute.h(260) : error C2143: syntax error : missing ';' before '}'"}]
[1418140917.187, "build_output", {"line": "c:\\Users\\Ryan\\repos\\mozilla-central\\media\\webrtc\\signaling/src/sdp/SdpAttribute.h(260) : error C2059: syntax error : ')'"}]
Flags: needinfo?(docfaraday)
Looks like a bug in MSVC's implementation of aggregate initialization? I might be able to work around it, but I would be flying pretty much blind, since I don't have that toolchain installed anywhere.

What do we actually support here?
Flags: needinfo?(docfaraday)
Can you try this patch and see if it fixed the bustage on 2012?
Flags: needinfo?(ryanvm)
currently trying patch on win8 vs 2012
With this patch I'm seeing:

11:28.37 JsepSessionImpl.cpp
11:28.37 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(125) : error C2143: syntax error : missing ')' before '{'
11:28.37 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(125) : error C2661: 'std::vector<_Ty>::push_back' : no overloaded function takes 0 arguments
11:28.37         with
11:28.37         [
11:28.37             _Ty=mozilla::SdpExtmapAttributeList::Extmap
11:28.37         ]
11:28.37 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(125) : error C2143: syntax error : missing ';' before '{'
11:28.37 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(128) : error C2143: syntax error : missing ';' before '}'
11:28.37 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(128) : error C2059: syntax error : ')'
11:28.37 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(143) : error C2143: syntax error : missing ')' before '{'
11:28.37 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(143) : error C2661: 'std::vector<_Ty>::push_back' : no overloaded function takes 0 arguments
11:28.37         with
11:28.37         [
11:28.37             _Ty=mozilla::SdpExtmapAttributeList::Extmap
11:28.37         ]
11:28.37 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(143) : error C2143: syntax error : missing ';' before '{'
11:28.38 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(146) : error C2143: syntax error : missing ';' before '}'
11:28.38 f:/Mozilla/mc/media/webrtc/signaling/src/jsep/JsepSessionImpl.cpp(146) : error C2059: syntax error : ')'
11:28.38
11:28.38 In the directory  /f/Mozilla/REL/media/webrtc/signaling/signaling_ecc
If you're not seeing errors in SdpAttribute, I'm on the right track. Can you attach a full build log so I don't miss anything else?
Flags: needinfo?(jmathies)
patch also failed locally for me
Fix another couple of errors.
Attachment #8533787 - Attachment is obsolete: true
Fix another (probable) error of the same type.
Attachment #8533843 - Attachment is obsolete: true
Comment on attachment 8533848 [details] [diff] [review]
(Attempted fix) Give MSVC2012 a hint about what these aggregate initializers mean.

This patch works for me. VS2010SP1
Attachment #8533848 - Flags: feedback+
me too, vs2012.
Flags: needinfo?(jmathies)
Flags: needinfo?(ryanvm)
Attachment #8533848 - Attachment is obsolete: true
Comment on attachment 8533868 [details] [diff] [review]
Give MSVC2012 a hint about what these aggregate initializers mean.

Review of attachment 8533868 [details] [diff] [review]:
-----------------------------------------------------------------

Unified try:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=b76c6490ce20

Non-unified try:

https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=2eb62d3a3d33
Attachment #8533868 - Flags: review?(drno)
comm-central tree has been affected by this issue too.

I pushed attachment 8533868 [details] [diff] [review] to try-comm-central. It worked fine.

https://treeherder.mozilla.org/ui/#/jobs?repo=try-comm-central&revision=df069ee91128

Just FYI.
Attachment #8533868 - Flags: review?(drno) → review+
https://hg.mozilla.org/mozilla-central/rev/fee489821da1
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Blocks: 1099556
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: