110916 - do not include realplayer in 4.x plugin scan

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Peter Lubczynski]

We've talked about this at our meetings. I'll come up with a patch and I'll let
Arun leave the sales pitch (for edt).

Comment 1

[Peter Lubczynski]

Attachment: patch to stop including realplayer from 4.x directory

this patch remove the real player mime type from isUnwantedPlugin which is only
called for a 4.x plugin runtime sweep on Windows.

Comment 2

[av (gone)]

Comment on attachment 58487 [details] [diff] [review]
patch to stop including realplayer from 4.x directory

r=av

Comment 3

[Marc Attinasi]

Comment on attachment 58487 [details] [diff] [review]
patch to stop including realplayer from 4.x directory

rs=attinasi

Comment 4

[Arun Ranganathan]

Sure enough, here's the "sales pitch" that peterl asked for ;-)
RealPlayer 8 currently recognizes N6.x and is bundled.  RealOne in all
likelihood will recognize Mozilla and other browsers based on Mozilla, including
embedded Gecko based browsers, since Real has been evangelized about
http://mozilla.org/projects/plugins/install-scheme.html
Therefore, having Gecko "sweep" for the 4.x install of Real isn't necessary (and
also not stable).  Sweeping for Quicktime may not be necessary soon, and
sweeping for Shockwave is no longer necessary.  Peter, ought similar bug be
created against sweeping for Shockwave?

Comment 5

[Peter Lubczynski]

Patch in the trunk, marking FIXED.

What's wrong with sweeping for Shockwave? AFAIK, ONLY the installer for the
plugin has been updated and it's not scriptable yet so it should be a better
user experience to leave the seep in because it's the same plugin. In fact, I
think all the plugins we do this for are in the same boat.

Comment 6

[Michael Dunn]

shirang, brent -- This needs to be verified on the trunk before we can plus (+)
for 094

Comment 7

[shrirang khanzode]

cannot completely verify unless bug 112097 is fixed. Since I cannot see 
the "about:plugins" listing, I won't say this is fixed and working fine. 
However, I did not install realplayer with today's trunk installation and went 
to a page that requires realplayer plugin, I got the default plugin..this means 
that the plugin was not picked up from the 4.x location. However, I need to see 
what "About:plugins" lists, then only I can confirm this. adding dependency to 
bug 112097

Comment 8

[Michael Dunn]

Shrirang, Can you validate with this link inlieu of "about:plugins"?
http://lxr.mozilla.org/mozilla/source/xpfe/global/resources/content/plugins.html

Comment 9

[shrirang khanzode]

build 2001112803. "About:plugins " is still broken for me. And, Michael, the 
link that u pointed to gives the same result (exception)..:(

Comment 10

[shrirang khanzode]

Ok, I could verify this one finally. Realplayer plugin is not getting picked up 
from the win 4.x plugins folder when realplayer is not installed in 6.x(which 
is what we want). Andrei helped me clear the hurdle of "About:plugins" .Thx. 

Comment 11

[Michael Dunn]

Please push to 094

Comment 12

[Marcia Knous [:marcia]]

EDT - Peter can you get this checked in - Embedding friends are pulling tomorrow.

Comment 13

[Peter Lubczynski]

I'd love to check this in. In fact, I've been ready since last night, but there
is no 0.9.4 mozilla or commercial branch tinderbox:

http://tinderbox.mozilla.org/showbuilds.cgi?tree=SeaMonkey-Embedding-Branch
http://warp.mcom.com/webtools/tinderbox/showbuilds.cgi?tree=SeaMonkey-Commercial-Branch

Could someone please let me know when this tinderbox comes back on-line or is it
okay to check-in without it? This is a simple patch that shouldn't break
anything but I'd like to try to follow procedures first. 

Others may be waiting for this too....

Comment 14

[Marcia Knous [:marcia]]

Peter - The tinderbox is back online. 

Comment 15

[Peter Lubczynski]

Thanks! patch in 0.9.4 branch.

Comment 16

[shrirang khanzode]

This is not working as required on the 0.9.4 'commercial branch' for me(12/05, 
12/06 :winNT, win98). Realplayer from 4.x plugins folder IS being picked 
up/listed in  "about:plugins".  However, 'works on mozilla and mfc embed 
builds' , confirmed with Peter. cc'ing granrose, leaf to see if incorrect builds 
are getting picked up since branch build id's(for builds 1205, 1206) say 
20011019 ?

Comment 17

[Christine Hoffman]

12/5 and 12/6 0.9.4ec builds have a problem and are not valid for verifications,
etc. Problem is being worked on now.

Comment 18

[shrirang khanzode]

finally verified on the commercial branch  build (1210) that this is fixed. 
Realplayer plugin is NOT picked up or used from 4.x plugins folder.

Comment 19

[shrirang khanzode]

adding keyword 'verified0.9.4' since this was verif on the 0.9.4 branch a while 
ago.