Closed Bug 1109162 Opened 10 years ago Closed 10 years ago

Do not validate commit names for non-landable patches

Categories

(Firefox OS Graveyard :: Gaia::GithubBot, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::GithubBot
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

Attachments

(1 file)

[PullReq] KevinGrandon:bug_1109162_do_not_validate_non_landable to mozilla:master
45 bytes, text/x-github-pull-request
kgrandon
: review+
Details | Review
See bug 1042673. It looks like Autolander did some validations on commits and pull request titles that did not have the R+. We should probably not perform these validations if the pull request is not landing (does not have an R+).
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Comment on attachment 8533967 [details] [review] [PullReq] KevinGrandon:bug_1109162_do_not_validate_non_landable to mozilla:master Just a simple movement of code, and all tests pass, so r=me.
Attachment #8533967 - Flags: review+
Keywords: checkin-needed
Keywords: checkin-needed
https://github.com/mozilla/autolander/pull/25 The pull request could not be applied to the integration branch. Please try again after current integration is complete.
Oops, I guess that's what happens when Autolander doesn't have access to the repository.
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: