Do not validate commit names for non-landable patches

RESOLVED FIXED

Status

Firefox OS
Gaia::GithubBot
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
See bug 1042673.

It looks like Autolander did some validations on commits and pull request titles that did not have the R+. We should probably not perform these validations if the pull request is not landing (does not have an R+).
(Assignee)

Updated

3 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED

Comment 1

3 years ago
Created attachment 8533967 [details] [review]
[PullReq] KevinGrandon:bug_1109162_do_not_validate_non_landable to mozilla:master
(Assignee)

Comment 2

3 years ago
Comment on attachment 8533967 [details] [review]
[PullReq] KevinGrandon:bug_1109162_do_not_validate_non_landable to mozilla:master

Just a simple movement of code, and all tests pass, so r=me.
Attachment #8533967 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 3

3 years ago
https://github.com/mozilla/autolander/pull/25

The pull request could not be applied to the integration branch. Please try again after current integration is complete.
(Assignee)

Comment 4

3 years ago
Oops, I guess that's what happens when Autolander doesn't have access to the repository.
Keywords: checkin-needed

Comment 5

3 years ago
Pull request has landed in master: https://github.com/mozilla/autolander/commit/704eaa2262b987f6dacec9b70899358dfcc015cb

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.