1109165 - Remove lock screen widget

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

Not possible on current Android versions. Doesn't work well with guest mode. We decided in today's meeting to rip it out.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

We need to remove from Fx37 and Fx36

Comment 2

[Wesley Johnston (:wesj)]

Attachment: Patch

This is the same thing we did on Aurora previously. There are probably still remnants of code left around with this. We can clean them up here or in follow ups?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8536671 [details] [diff] [review]
Patch

File follow up for removing the rest. Make sure you put some hints as to where else to remove things.

Comment 4

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/fx-team/rev/44916c82049c

Comment 5

[Wesley Johnston (:wesj)]

Comment on attachment 8536671 [details] [diff] [review]
Patch

Approval Request Comment
[Feature/regressing bug #]: bug 815682
[User impact if declined]: strange behaviors with the widget
[Describe test coverage new/current, TBPL]: none
[Risks and why]: low risk. turning off a feature. Same patch we've used to turn it off before.
[String/UUID change made/needed]: none.

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44916c82049c

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bdb2bea5ff32

Comment 8

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in:
Firefox for Android 37.0a1 (2014-12-18);
Firefox for Android 36.0a2 (2014-12-18);

Device: Nexus 4 (Android 4.4.4).