Closed
Bug 1109216
Opened 10 years ago
Closed 10 years ago
Do more MediaPromise chaining in OmxMediaReader::Shutdown
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
In bug 1108707, I ran into an issue where invoking MediaDecoderReader::Shutdown at the end of MediaOmxReader::Shutdown caused memory hazards, because MediaOmxReader::ReleaseMediaResources was racing with the main-thread-dispatched MediaOmxReader::ReleaseDecoder.
The quick solution was just to reorder things like they used to be. But it would be nicer to chain the dispatch of the main thread runnables off of Promise resolution. I'll do this once bug 1108707 lands.
|
Assignee | |
Comment 1•10 years ago
|
||
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Comment 3•10 years ago
|
||
Attachment #8535307 -
Flags: review?(cpearce)
|
||
Updated•10 years ago
|
Attachment #8535307 -
Flags: review?(cpearce) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•