Closed Bug 1109233 Opened 5 years ago Closed 5 years ago

Replace `Assert.isTrue(false...)` with ``


(Firefox for Android :: General, defect)

Not set



Firefox 37


(Reporter: mcomella, Assigned: nivvedan, Mentored)


(Whiteboard: [lang=java][good first bug])


(1 file)

There are a few assertions in the code base that use `Assert.isTrue(false...)` [1]. For readability and simplicity of code, these are equivalent to, and should be replaced with, `` [2].

To start, set up a build environment - you can see the instructions here:

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see

Thanks and happy coding! ^_^

Hi Micheal,

I have just set up my build environment, and would like to work on this bug.
Could you please assign me to it?
> I have just set up my build environment, and would like to work on this bug.
> Could you please assign me to it?

Just go ahead and start work; no need to be marked as assigned until we have a patch to show.
Sure, you've been assigned - let me know if you need anything!
Assignee: nobody → nivvedan
Attached patch v1Splinter Review
Attachment #8534796 - Flags: review?(michael.l.comella)
Comment on attachment 8534796 [details] [diff] [review]

Review of attachment 8534796 [details] [diff] [review]:

Great, looks good to me!

In comment 5 I posted a link to a run of our Try server. When it goes green, feel free to add the "checkin-needed" keyword [1] to get your patch checked in. Note that all patches landed with checkin-needed need an associated green Try run.

Of course, let me know if you need help reading the results.

Thanks for your help! :)

If you're looking for a good followup bug, I think bug 938845 would be straight-forward (but perhaps tedious D: !), while bug 926234 requires a bit of SQL knowledge to help untangle our database and bug 1108084 requires digging into our favicon code. If none of these work for you, let me know!
Attachment #8534796 - Flags: review?(michael.l.comella) → review+
Keywords: checkin-needed
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [lang=java][good first bug] → [lang=java][good first bug][fixed-in-fx-team]
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [lang=java][good first bug][fixed-in-fx-team] → [lang=java][good first bug]
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.