1109240 - [Camera] Remove unsolicited event callbacks from Camera app

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: pull-request (master)

Comment 2

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8533933 [details] [review]
pull-request (master)

LGTM

Comment 3

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://github.com/mozilla-b2g/gaia/commit/2839fecb02a3f17d0306c4f6fcc894b93791e311

Comment 4

[Zac C (:zac)]

Reverted for busting camera app as per Wilson's comment here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1109573#c2

https://github.com/mozilla-b2g/gaia/commit/37819febbe4d700f34377ba04bc680c973079dd2

Switch the ni? to this bug to de-dupe the bugs.

Comment 5

[Mike Habicher [:mikeh] (high bugzilla latency)]

I just reapplied the patch in bug 1109240 to a fresh pull/build of my gecko and gaia trees, and the Camera app works as expected, including face detection.

Gonk  v188-1
Gecko b2g-inbound/219028:a6282dfb2764
Gaia  master/e04ab7651b1e0c67516e1cef7aa4bc6072529885

Comment 6

[Mike Habicher [:mikeh] (high bugzilla latency)]

Okay, the problem only seems to happen when *re*opening the camera.

STR:
1. open Camera app
2. press Home button
3. reopen Camera app

Observed: spinner.

Expected: active viewfinder.

Comment 7

[Mike Habicher [:mikeh] (high bugzilla latency)]

Wilson, is this the error you were seeing in bug 1109573?

[JavaScript Error: "TypeError: faces is undefined" {file: "app://camera.gaiamobile.org/js/main.js" line: 10809}]

Comment 8

[Mike Habicher [:mikeh] (high bugzilla latency)]

Attachment: pull-request (master)

Fix bustage in bug 1109573. The difference is:

1. https://github.com/mozilla-b2g/gaia/pull/26699/files#diff-b2ec18150f47bf7f826e5cbc8c49fddeR88
2. https://github.com/mozilla-b2g/gaia/pull/26699/files#diff-b2ec18150f47bf7f826e5cbc8c49fddeR105

Comment 9

[Mike Habicher [:mikeh] (high bugzilla latency)]

https://github.com/mozilla-b2g/gaia/commit/35ae5aeac71b5790399c5104442692664d649432

(Take 2.)

Comment 10

[Wilson Page [:wilsonpage]]

(In reply to Mike Habicher [:mikeh] from comment #7)
> Wilson, is this the error you were seeing in bug 1109573?
> 
> [JavaScript Error: "TypeError: faces is undefined" {file:
> "app://camera.gaiamobile.org/js/main.js" line: 10809}]

Yeah, that's the one.