Closed
Bug 1109287
Opened 10 years ago
Closed 10 years ago
Change the test runner to SlimerJS and add some more sample unit tests
Categories
(Firefox OS Graveyard :: Gaia::Loop, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: amac, Assigned: amac)
References
Details
Attachments
(1 file)
The PhantomJS engine we were using to run tests run on Webkit, not on Gecko. And it runs on an old version of Webkit, on top of that. So it cannot parse some of our code, which puts a damper on it actually being able to test it.
This bug is to change the test runner to SlimerJS, and to add some more examples (real tests too), to try to bootstrap the unit tests.
| Assignee | ||
Comment 1•10 years ago
|
||
Please note that since this changes the package.json file, you'll need to run
npm update
(and then wait for it to download half of the internet) before being able to try this out.
Attachment #8533944 -
Flags: review?(crdlc)
Comment 2•10 years ago
|
||
Comment on attachment 8533944 [details] [review]
Change the test runner and add some sample tests.
Good job as always, thanks a lot
Attachment #8533944 -
Flags: review?(crdlc) → review+
Comment 3•10 years ago
|
||
Landed on master at:
https://github.com/mozilla-b2g/firefoxos-loop-client/commit/3b9da7ef7ea752d1452c3264f2027dcd977596d7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•