1109308 - Intermittent failing test, shared/js/text_utils.js FontSizeUtils.getOverflowCount Should be overflow width divided by character width

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Kevin Grandon :kgrandon]

TEST-UNEXPECTED-FAIL | null | [sharedtest-test/unit/font_size_utils_test.js] shared/js/text_utils.js FontSizeUtils.getOverflowCount Should be overflow width divided by character width
Error: expected 150 to equal 149
    at chaiAssert (app://sharedtest.gaiamobile.org/common/test/helper.js:32:1)
    at equal (app://sharedtest.gaiamobile.org/common/vendor/chai/chai.js:2438:1)
    at (anonymous) (app://sharedtest.gaiamobile.org/test/unit/font_size_utils_test.js:302:7)
    at wrapper (app://sharedtest.gaiamobile.org/common/test/mocha_generators.js:62:19)
    at run (app://sharedtest.gaiamobile.org/common/vendor/mocha/mocha.js:3709:7)
    at runTest (app://sharedtest.gaiamobile.org/common/vendor/mocha/mocha.js:4081:5)
    at (anonymous) (app://sharedtest.gaiamobile.org/common/vendor/mocha/mocha.js:4127:7)
    at next (app://sharedtest.gaiamobile.org/common/vendor/mocha/mocha.js:4007:1)
    at (anonymous) (app://sharedtest.gaiamobile.org/common/vendor/mocha/mocha.js:4016:7)
    at next (app://sharedtest.gaiamobile.org/common/vendor/mocha/mocha.js:3964:1)
    at (anonymous) (app://sharedtest.gaiamobile.org/common/vendor/mocha/mocha.js:3984:5)
    at (anonymous) (app://sharedtest.gaiamobile.org/common/vendor/mocha/mocha.js:4932:28)

As seen on: https://taskcluster-artifacts.s3-us-west-2.amazonaws.com/4nP0kpx0R1SikMgMfPgLCQ/3/public/logs/live_backing.log?AWSAccessKeyId=AKIAIZOQG4W6WG3PH3RQ&Expires=1418164634&Signature=QuZJ%2Fwn4kGd5LthGPr40KpPwK4Q%3D

Comment 1

[Kevin Grandon :kgrandon]

Attachment: Github pull request

Mike - what do you think? Can we make the assertion a bit more lose to handle the difference in font rendering across various platforms?

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8534746 [details] [review]
Github pull request

Good solution.

Comment 3

[Kevin Grandon :kgrandon]

Ok, let's land this for now, and we can figure out a more-perfect solution in the future if we want.

https://github.com/mozilla-b2g/gaia/commit/163a9659fcd1ac29397aa0cb0b1a0f10a69a75fd