1109311 - Fix the -Wundefined-bool-conversion warning in nsHtml5TreeBuilder.cpp resulting from checking the value of this; r=hsivonen

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[(no longer active)]

Clang gives the following warning for this code:

'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true

Comment 1

[(no longer active)]

Attachment: Fix the -Wundefined-bool-conversion warning in nsHtml5TreeBuilder.cpp resulting from checking the value of this; r=hsivonen

Comment 2

[:Cykesiopka]

FWIW, Bug 1073707 is about the same issue, but the patch there takes a #pragma approach.

Comment 3

[Henri Sivonen (:hsivonen) (away from Bugzilla until 2026-01-05)]

Comment on attachment 8533978 [details] [diff] [review]
Fix the -Wundefined-bool-conversion warning in nsHtml5TreeBuilder.cpp resulting from checking the value of this; r=hsivonen

Normally, editing generating code like this wouldn't be OK, but I made the corresponding change to the generator:
https://hg.mozilla.org/projects/htmlparser/rev/e2fb8b3f4bc0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/15870672599a