Closed
Bug 1109311
Opened 10 years ago
Closed 10 years ago
Fix the -Wundefined-bool-conversion warning in nsHtml5TreeBuilder.cpp resulting from checking the value of this; r=hsivonen
Categories
(Core :: DOM: HTML Parser, defect)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
Clang gives the following warning for this code: 'this' pointer cannot be null in well-defined C++ code; pointer may be assumed to always convert to true
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → ehsan.akhgari
Assignee | ||
Updated•10 years ago
|
Attachment #8533978 -
Flags: review?(hsivonen)
Comment 2•10 years ago
|
||
FWIW, Bug 1073707 is about the same issue, but the patch there takes a #pragma approach.
Comment 3•10 years ago
|
||
Comment on attachment 8533978 [details] [diff] [review] Fix the -Wundefined-bool-conversion warning in nsHtml5TreeBuilder.cpp resulting from checking the value of this; r=hsivonen Normally, editing generating code like this wouldn't be OK, but I made the corresponding change to the generator: https://hg.mozilla.org/projects/htmlparser/rev/e2fb8b3f4bc0
Attachment #8533978 -
Flags: review?(hsivonen) → review+
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/15870672599a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•