Created attachment 8534041 [details] ASAN log email@example.com received the following report: Attached file will expose an invalid memcpy in openh264. I haven't done a thorough analysis (and I feel I'm probably not skilled enough to judge exploitability). I've attached address sanitizer output and a gdb backtrace for further analysis. This was found with american fuzzy lop. cu, -- Hanno Böck http://hboeck.de/ mail/jabber: firstname.lastname@example.org GPG: BBB51E42
Ethan: the symptoms seem like they might be exploitable. Can you tell?
I will have the team analyze it tonight. The crash looks like it's in CabacContextInit which is not in the v1.1-Firefox34 branch that we are shipping, but is in the master branch which I'm hoping to branch from soon for our next FF build. We will make sure it's fixed before we call our next build.
Fix reviewed here: https://rbcommons.com/s/OpenH264/r/1008/ And merged here: https://github.com/cisco/openh264/commit/7f27198c6857096d755b592c7f55f7b1469c50ab So it should be in OpenH264 v1.3
Keywords: csectype-bounds, sec-critical
Component: WebRTC: Audio/Video → OpenH264
Product: Core → Plugins
Randell, when are we going to take OpenH264 1.3 on Firefox?
status-firefox34: --- → wontfix
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
status-firefox-esr31: --- → unaffected
tracking-firefox37: --- → +
The bug to get OpenH264 1.3 into Firefox is here - Bug 1113777
From bug 1113777: "My assumption is that we'll put this version in for 36+ and let it ride the train from there."
status-firefox38: --- → affected
tracking-firefox37: + → ---
OpenH264 1.3 has this fix and is now downloaded for Firefox 34+ so marking this as fixed.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
status-firefox35: affected → fixed
status-firefox36: affected → fixed
status-firefox37: affected → fixed
status-firefox38: affected → fixed
status-firefox39: --- → fixed
You need to log in before you can comment on or make changes to this bug.