110939 - resetting document.location doesn't display new page[form sub]

Status: VERIFIED INVALID

(Core :: DOM: Core & HTML, defect)

Description

[Leston Buell]

Resetting document.location doesn't display the new page... at least in the
simplest case. It seems that there is some timing involved. If i add an alert to
a script right after the location reset, then the new page displays. I'll attach
a minimal testcase.

This is maddening! I spent hours trying to get a script to work, only to find
that this was a Mozilla bug and that the script behaved correctly in Konqueror.

Using Linux trunk build 2001-11-18-06.

Comment 1

[Leston Buell]

Attachment: test case

Self-explanatory test case.

Comment 2

[Boris Zbarsky [:bzbarsky]]

worksforme, linux build from 2001-11-18.  Definitely sounds like a timing
issue..

DOM0, not JS engine

Comment 3

[Phil Schwartau]

Using Mozilla trunk binary 20011120xx on WinNT.
Confirming bug. I saved the testcase locally as 

      file:///C:/WINNT/Profiles/pschwartau/Desktop/110939.html

When I clicked on the first button ("Change location."), this 
URL was appended with question mark:

      file:///C:/WINNT/Profiles/pschwartau/Desktop/110939.html?


The URL http://www.fizzylogic.com/ never appeared in the URL bar.
And nothing happened. No new page. Note: no errors in JS Console.


Reassigning to Form Submission. The upper button uses this HTML:

<form name="form1" onsubmit="changeLocation1();">
  <input type="submit" value="Change location.">

If you change this to 

<form name="form1">
  <input type="button" value="Change location." onclick="changeLocation1();">


then the upper button seems to work fine without the alertbox added....

Comment 4

[Leston Buell]

The problem seems to be that when code is executed "onSubmit", the "submit" task
doesn't wait for the JavaScript to be complete executed before submitting. (This
is just what i surmise after fiddling with a script for a few hours.)

Another thing to try is to reset the form's action attribute in the form's
onSubmit attribute:

     <form
        onsubmit="document.FORMNAME.action=http://www.toothpicksRus.com">

As i recall, the submit will still incorrectly use the old action attribute.

Comment 5

[Leston Buell]

> Another thing to try is to reset the form's action attribute in the form's
> onSubmit attribute

Oops. I was developing a simple test case for this, and this seems to be working
correctly. Sorry i didn't double-check that ahead of time. However, i do know
that i have in some case tried to reset the form "action" inside a function call
made from onSubmit, where the submit barged ahead, ignoring this variable i had
just reset.

Comment 6

[Alexandru Savulov]

setting milestone

Comment 7

[John Keiser (jkeiser)]

This seems like expected behavior to me.  Here is the sequence of events:

1. submit button clicked
2. onSubmit() called
3. document.location changed, browser starts to change location
4. onSubmit() returns, does not return false (this means it should submit)
5. form submits, changing location again

Steps 3 and 5 should act about the same as when you click on link A, it starts
loading that link, and then you click on link B.  Link B is the one that
eventually shows up.  Try it.  Click on "Show dependency tree" on this page and
then quickly click on "Show dependency graph" below it.  It will end up on the
graph, not the tree.

The reason you are seeing it with the alert is the same with links as well.  Try
it: if you click on "Show dependency tree" and then just before it's about to
show the tree page you click on "Show dependency graph", it goes to tree anyway
(and stays there).

The lesson: return false at the end of onSubmit if you want to make sure you
don't submit the form.

Not a bug, I say.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase that returns false

Comment 9

[Boris Zbarsky [:bzbarsky]]

For some reason, returning false is _not_ cancelling the form submission.

Note that NS4 exhibits the same exact behavior we do...

Comment 10

[John P Baker]

Your attachment 65940 [details] is not returning false from the javascript, should be 
<form name="form1" onsubmit="return changeLocation1();">
so the only difference is the delay caused by the alert.

First example (attachment 58508 [details]) should be
<form name="form1" onsubmit="changeLocation1();return false">

Not all browsers behave like this though!

Comment 11

[Boris Zbarsky [:bzbarsky]]

Ah, indeed.  I suck.  This bug is invalid, then.

Comment 12

[John Keiser (jkeiser)]

Agreed.  This order of events is valid and even preferred.

Comment 13

[Vladimir Ermakov]

verifying