110940 - [PATCH]order List ID does not display correctly after change the order

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[Frank Tang]

It is related to lack of reflow of the bullet frame . I can reproduce this on
2001111403 trunk build.

Reproduce procedure:
1. open composer (or mail composition)
2. type several lines with ENTER to hard break the line. For example, tyep "aaa"
in the first line, "bbb" for the second, "ccc", "ddd", "eee", "fff", "ggg" for
the 3rd - 7th lines
3. select all the lines
4. click [numbered list] icon or select "Format:List:Numbered" menu
5. the 7 lines will be displayed as

1. aaa
2. bbb
3. ccc
4. ddd
5. eee
6. fff
7. ggg

this is ok
6. now, select only the 3-4 lines, and click [->] icon or hit Ctrl + [ key to
increase the ident
actual result


1. aaa
2. bbb
   1. ccc
   2. ddd
   3. eee
6. fff
7. ggg

notice that the id for "fff" and "ggg" is still 6 and 7. If you scroll then it
will display as 3 and 4. 

expect result:

1. aaa
2. bbb
   1. ccc
   2. ddd
   3. eee
3. fff
4. ggg

Comment 1

[sujay]

--> jfrancis..list dude.

Comment 2

[kinmoz]

--> kin - this is probably a layout issue as ftang pointed out.

Comment 3

[Kevin McCluskey (gone)]

Looks like an invalidation problem. The layout is correct, if you force a
re-paint by placing another window over the top and remove it, then it will
display correctly.

Marking EDITORBASE+.

Comment 4

[kinmoz]

--> mozilla1.0

Comment 5

[kinmoz]

Attachment: JS Test Case

Comment 6

[kinmoz]

Attachment: Patch Rev 1

Forcing an invalidate when changing the bullet frame's ordinal seems to fix the
problem.

Comment 7

[Kevin McCluskey (gone)]

Comment on attachment 76810 [details] [diff] [review]
Patch Rev 1

r=[e-mail]

Comment 8

[kinmoz]

Attachment: JS Test Case 2 (Shows more serious invalidation/reflow problems)

During my testing I created this test case which seems to expose more serious
invalidation/reflow problems that Patch Rev 1 won't fix.

Comment 9

[Chris Waterson]

Comment on attachment 76810 [details] [diff] [review]
Patch Rev 1

sr=waterson. Please do file another bug (or bugs) on the other issues.

Comment 10

[Chris Waterson]

Comment on attachment 76810 [details] [diff] [review]
Patch Rev 1

sr=waterson. Please do file another bug (or bugs) on the other issues.

Comment 11

[kinmoz]

Filed bug 135767 to cover the problems I'm seeing with JS Test Case 2.

Comment 12

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin to 1.0.

Comment 13

[Asa Dotzler [:asa]]

Comment on attachment 76810 [details] [diff] [review]
Patch Rev 1

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 14

[kinmoz]

Fixed on TRUNK:

    mozilla/layout/html/base/src/nsBlockFrame.cpp  revision 3.499

Comment 15

[kinmoz]

Fix checked into MOZILLA_1_0_0_BRANCH:

    mozilla/layout/html/base/src/nsBlockFrame.cpp  revision 3.496.2.3

Comment 16

[sujay]

verified in 4/23 trunk build.

will also verify on the branch and comment here.

Comment 17

[sujay]

verified in 4/23 branch build.